Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruby: Unskip WAF blocking tests for ruby #3586

Merged
merged 2 commits into from
Nov 29, 2024
Merged

Conversation

y9v
Copy link
Member

@y9v y9v commented Nov 28, 2024

Motivation

Those tests were disabled as a temporary fix:
#3584

This PR should have fix those tests:
DataDog/dd-trace-rb#4173

Another thing that needs to be fixed after the update to 1.17.0.0.0:
DataDog/dd-trace-rb#4175

Changes

WAF blocking tests are enabled again for ruby.

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@y9v y9v marked this pull request as ready for review November 29, 2024 10:42
@y9v y9v requested review from a team as code owners November 29, 2024 10:42
@y9v y9v merged commit 78b9d10 into main Nov 29, 2024
281 checks passed
@y9v y9v deleted the unskip-waf-blocking-tests-for-ruby branch November 29, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants