Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruby: Unskip WAF blocking tests for ruby #3586

Merged
merged 2 commits into from
Nov 29, 2024
Merged

Ruby: Unskip WAF blocking tests for ruby #3586

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a57a7cb
Unskip WAF blocking tests for ruby
y9v Nov 28, 2024
cc61d3c
Merge branch 'main' into unskip-waf-blocking-tests-for-ruby
y9v Nov 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions tests/appsec/waf/test_blocking.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,15 +222,13 @@ class Test_CustomBlockingResponse:
def setup_custom_status_code(self):
self.r_cst = weblog.get("/waf/", headers={"User-Agent": "Canary/v1"})

@bug(context.library == "[email protected]", reason="APPSEC-56056")
def test_custom_status_code(self):
"""Block with a custom HTTP status code"""
assert self.r_cst.status_code == 401

def setup_custom_redirect(self):
self.r_cr = weblog.get("/waf/", headers={"User-Agent": "Canary/v2"}, allow_redirects=False)

@bug(context.library == "[email protected]", reason="APPSEC-56056")
def test_custom_redirect(self):
"""Block with an HTTP redirection"""
assert self.r_cr.status_code == 301
Expand All @@ -239,7 +237,6 @@ def test_custom_redirect(self):
def setup_custom_redirect_wrong_status_code(self):
self.r_cr = weblog.get("/waf/", headers={"User-Agent": "Canary/v3"}, allow_redirects=False)

@bug(context.library == "[email protected]", reason="APPSEC-56056")
def test_custom_redirect_wrong_status_code(self):
"""Block with an HTTP redirection but default to 303 status code, because the configured status code is not a valid redirect status code"""
assert self.r_cr.status_code == 303
Expand Down