Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Java] Enable more easy wins #4018

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

manuel-alvarez-alvarez
Copy link
Member

@manuel-alvarez-alvarez manuel-alvarez-alvarez commented Feb 7, 2025

Motivation

Changes

  • Set the actual version supporting the test tests/test_library_conf.py::Test_HeaderTags as discovered by the check_version.sh script:
Running java 1.35.0 spring-boot
[1.35.0] XPASS: tests/test_library_conf.py::Test_HeaderTags::test_trace_header_tags_basic
  • Update the version support for tests/appsec/waf/test_addresses.py::Test_BodyJson in vert.x 4.0 that will be released with the next tracer version.

APPSEC-54879

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@manuel-alvarez-alvarez manuel-alvarez-alvarez changed the title [JavaUpdate java manifest for Test_HeaderTags [Java] Configure manifest for Test_HeaderTags Feb 7, 2025
@manuel-alvarez-alvarez manuel-alvarez-alvarez force-pushed the malvarez/java-identify-easy-wins branch from ae3d16b to fdbb96b Compare February 7, 2025 11:18
@manuel-alvarez-alvarez manuel-alvarez-alvarez changed the title [Java] Configure manifest for Test_HeaderTags [Java] Enable more easy wins Feb 7, 2025
@manuel-alvarez-alvarez manuel-alvarez-alvarez marked this pull request as ready for review February 7, 2025 12:05
@manuel-alvarez-alvarez manuel-alvarez-alvarez force-pushed the malvarez/java-identify-easy-wins branch from fdbb96b to be2ca65 Compare February 7, 2025 12:43
@manuel-alvarez-alvarez manuel-alvarez-alvarez merged commit f32f333 into main Feb 7, 2025
52 checks passed
@manuel-alvarez-alvarez manuel-alvarez-alvarez deleted the malvarez/java-identify-easy-wins branch February 7, 2025 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants