-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TextLocator/implement literature search #172
Conversation
WIP commit, search and finding matching geometries done, further steps towards UI yet to be done
…/text-locator-literature-search
…aport/polar into feature/text-locator-literature-search
…aport/polar into feature/text-locator-literature-search
…/text-locator-literature-search
There has been a change in how the backend returns stuff. This is now reflected upon in the frontend.
…/text-locator-literature-search
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After clicking myself through the related places to A review on substances and processes relevant for optical remote sensing of extremely turbid marine areas, with a focus on the Wadden Sea
it is a bit confusing to me why some places have highlighted geometries and others don't. How does this happen? Is this something that is addressed in #194?
packages/clients/textLocator/src/utils/textLocatorBackend/findLiterature/selectLiterature.ts
Show resolved
Hide resolved
packages/clients/textLocator/src/utils/textLocatorBackend/findLiterature/selectLiterature.ts
Outdated
Show resolved
Hide resolved
packages/clients/textLocator/src/utils/textLocatorBackend/findLiterature/selectLiterature.ts
Outdated
Show resolved
Hide resolved
packages/clients/textLocator/src/utils/textLocatorBackend/findLiterature/selectLiterature.ts
Show resolved
Hide resolved
packages/clients/textLocator/src/utils/textLocatorBackend/findLiterature/selectLiterature.ts
Show resolved
Hide resolved
apply suggestion "replace random word with usual word" Co-authored-by: Pascal Röhling <[email protected]>
apply suggestion "unshout BREAKING changelog entry" Co-authored-by: Pascal Röhling <[email protected]>
apply suggestion "remove duplicate newline" Co-authored-by: Pascal Röhling <[email protected]>
apply suggestion "tense" Co-authored-by: Pascal Röhling <[email protected]>
apply suggestion "remove redundant types" Co-authored-by: Pascal Röhling <[email protected]>
…uffix.ts apply suggestion "remove outdated TODO" Co-authored-by: Pascal Röhling <[email protected]>
…Literature/searchLiterature.ts apply suggestion "remove optional type" Co-authored-by: Pascal Röhling <[email protected]>
…Literature/selectLiterature.ts apply suggestion "model getters in type correctly" Co-authored-by: Pascal Röhling <[email protected]>
…Literature/selectLiterature.ts apply suggestion "model getters in type correctly" Co-authored-by: Pascal Röhling <[email protected]>
…ub.com/Dataport/polar into feature/text-locator-literature-search
Actually, all places have geometries, but not all are clearly visible.
Actual highlighting (making places brighter/darker) is a concern of that PR, yes. |
…makeTreeView.ts apply suggestion "reflavour code" Co-authored-by: Pascal Röhling <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary
Instructions for local reproduction and review
npm run textLocator:dev