Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TextLocator/implement literature search #172

Merged
merged 42 commits into from
Oct 25, 2024

Conversation

warm-coolguy
Copy link
Member

@warm-coolguy warm-coolguy commented Sep 4, 2024

Summary

  • Implemented document search, that is, the AddressSearch bar now also offers results for documents, and clicking on one will retrieve a list of toponyms from the backend and resolve them against the gazetteer. Previously, we had a "get all documents regarding place" functionality. Now, a "get all places regarding document" feature is implemented.
  • Additionally to the AddressSearch, this can be triggered on documents found in the previously implemented way; the "get all places regarding document" functionality is available from within the GeoSearch result display with one of the right-hand buttons.
  • The backend API changed. The changes have been adapted to.
  • The "heatmap" feature is currently not working. This will be adressed in a follow-up PR. For now, the feature correctly zooms, but the map stays cold. (Fix/text locator heatmap #195)
  • The result display may become confusing due to a growing number of ways to fill in the contents. To address this issue, further context information ("How did I get this result?") will be added in a separate PR. (Feature/text locator result source indicator #194)

Instructions for local reproduction and review

npm run textLocator:dev

  • Test new search features.
    • (AddressSearch) Try searching for "Marine" and clicking the first literature result. (Other results may not yield toponyms relevant to the used gazetteer.) (Edit: Meanwhile, wildcard has been implemented. Also search for "Marin" to see if it works; should yield results now.)
    • (GeoSearch) Click into the map, e.g. on Neuwerk. In the result section, when having "Text" as sorting order, click the magnifying glass icon to load all geometries regarding any text.
  • Since the backend API was changed and everything required touching, testing everything across the board seems to be in order. Exceptions have been noted in the Summary.

WIP commit, search and finding matching geometries done, further steps
towards UI yet to be done
@warm-coolguy warm-coolguy added the enhancement New feature or request label Sep 4, 2024
@warm-coolguy warm-coolguy self-assigned this Sep 4, 2024
@warm-coolguy warm-coolguy changed the title implement literature search for custom backend TextLocator/implement literature search Sep 4, 2024
warm-coolguy and others added 23 commits September 4, 2024 14:18
There has been a change in how the backend returns stuff. This is now
reflected upon in the frontend.
@warm-coolguy warm-coolguy marked this pull request as ready for review October 1, 2024 08:04
Copy link
Member

@dopenguin dopenguin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After clicking myself through the related places to A review on substances and processes relevant for optical remote sensing of extremely turbid marine areas, with a focus on the Wadden Sea it is a bit confusing to me why some places have highlighted geometries and others don't. How does this happen? Is this something that is addressed in #194?

🏓 @warm-coolguy

warm-coolguy and others added 13 commits October 11, 2024 07:20
apply suggestion "replace random word with usual word"

Co-authored-by: Pascal Röhling <[email protected]>
apply suggestion "unshout BREAKING changelog entry"

Co-authored-by: Pascal Röhling <[email protected]>
apply suggestion "remove duplicate newline"

Co-authored-by: Pascal Röhling <[email protected]>
apply suggestion "tense"

Co-authored-by: Pascal Röhling <[email protected]>
apply suggestion "remove redundant types"

Co-authored-by: Pascal Röhling <[email protected]>
…uffix.ts


apply suggestion "remove outdated TODO"

Co-authored-by: Pascal Röhling <[email protected]>
…Literature/searchLiterature.ts


apply suggestion "remove optional type"

Co-authored-by: Pascal Röhling <[email protected]>
…Literature/selectLiterature.ts


apply suggestion "model getters in type correctly"

Co-authored-by: Pascal Röhling <[email protected]>
…Literature/selectLiterature.ts


apply suggestion "model getters in type correctly"

Co-authored-by: Pascal Röhling <[email protected]>
@warm-coolguy
Copy link
Member Author

After clicking myself through the related places to A review on substances and processes relevant for optical remote sensing of extremely turbid marine areas, with a focus on the Wadden Sea it is a bit confusing to me why some places have highlighted geometries and others don't. How does this happen? Is this something that is addressed in #194?

🏓 @warm-coolguy

Actually, all places have geometries, but not all are clearly visible.

  • Norderney is a split geometry of two smaller things and may be hard to see (maybe it's something rare, like Neuwerk, which is part of Hamburg – for our concern, we trust the geographic data is correct as presented)
  • Some entries are just off-limits the map in the new data set; since we're focusing on the North Sea Coast, I deem this an issue of the underlying testing data atm; I'll note that in the internal issue tracker

Actual highlighting (making places brighter/darker) is a concern of that PR, yes.

🏓 @dopenguin

warm-coolguy and others added 2 commits October 22, 2024 06:26
…makeTreeView.ts


apply suggestion "reflavour code"

Co-authored-by: Pascal Röhling <[email protected]>
Copy link
Member

@dopenguin dopenguin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@warm-coolguy warm-coolguy merged commit 7afd7e5 into main Oct 25, 2024
4 checks passed
@warm-coolguy warm-coolguy deleted the feature/text-locator-literature-search branch October 25, 2024 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants