Feature/text locator result source indicator #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dopenguin
reviewed
Nov 7, 2024
…//github.com/Dataport/polar into feature/text-locator-result-source-indicator
🏓 @dopenguin The changelog entry has been unmissingfied. b3b5249 |
dopenguin
approved these changes
Nov 8, 2024
apply suggestion "imperator changelogs" Co-authored-by: Pascal Röhling <[email protected]>
…/text-locator-result-source-indicator
…//github.com/Dataport/polar into feature/text-locator-result-source-indicator
warm-coolguy
deleted the
feature/text-locator-result-source-indicator
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The results in the TextLocator client may seem confusing at times, since not all places to each piece of literature, nor all pieces of literature to each place are shown at all times. However, this must stay this way; else, we'd pretty much load the whole database due to overlap chains. (Literature has place, which has other literature, which has other places, which ...)
Still, users may have problems in understanding this in detail. To help with this, a minimal indicator has been placed in the UI so that the source for the currently visible results is kept. This may later be extended by a more sophisticated description in e.g. a tooltip, depending on the customer review. For now, it's mostly meant to transport the idea and implement the feature roughly.
Instructions for local reproduction and review
Run TextLocator and try all different ways to display the search results. All major paths (search for literature/toponym/geometry) have their own respective display string.
Relevant tickets, issues, et cetera
Based/Blocks on #172