Skip to content

remove check for support for extended attributes from script for using build container #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 7, 2022
Merged

remove check for support for extended attributes from script for using build container #189

merged 1 commit into from
Oct 7, 2022

Conversation

boegel
Copy link
Contributor

@boegel boegel commented Oct 7, 2022

The attr check isn't needed anymore thanks to EESSI/filesystem-layer#125, and attr is often not available anyway...

@boegel boegel requested a review from trz42 October 7, 2022 19:07
@boegel boegel mentioned this pull request Oct 7, 2022
Merged
trz42
trz42 approved these changes Oct 7, 2022
View reviewed changes
Copy link
Collaborator

@trz42 trz42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Cleaner than just commenting out the exit!

@trz42 trz42 merged commit 441ff01 into EESSI:main Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trz42 trz42 trz42 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@boegel @trz42