fix(date-picker): set appropriate scale for month header actions #13922
+15
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
driskull
added
the
pr ready for visual snapshots
github-actions
bot
added
the
bug
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the scale property handling for month header navigation actions in the date-picker component. Previously, the navigation buttons (next/prev month) were forced to use either "l" or "m" scale regardless of the parent's scale, which has been corrected to inherit the scale directly.
Changes:
- Removed scale transformation logic that was mapping "s" scale to "m" for month header actions
- Updated test story to remove hardcoded scale attribute, allowing proper scale testing
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/components/src/components/date-picker-month-header/date-picker-month-header.tsx | Simplified scale assignment to pass through the component's scale property directly to month navigation actions |
| packages/components/src/components/date-picker/date-picker.stories.ts | Removed scale attribute from breakpoint test story to allow proper scale inheritance testing |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
driskull
added
pr ready for visual snapshots
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
driskull
added
pr ready for visual snapshots
driskull
removed
the
pr ready for visual snapshots
driskull
added
the
pr ready for visual snapshots
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #13914
Summary
fixes the scale property handling for month header navigation actions in the date-picker component. Previously, the navigation buttons (next/prev month) were forced to use either "l" or "m" scale regardless of the parent's scale, which has been corrected to inherit the scale directly.