Skip to content

fix(date-picker): set appropriate scale for month header actions #13922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
driskull wants to merge 6 commits into
base: dev
Choose a base branch
from
+15 −1
Open

fix(date-picker): set appropriate scale for month header actions #13922

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
fbc14c7
fix(date-picker): set appropriate scale for month header actions #13914
driskull Feb 12, 2026
12ae09d
cleanup
driskull Feb 12, 2026
71f7a7e
add test
driskull Feb 12, 2026
6edd85d
add test
driskull Feb 12, 2026
bc96cba
Update date-picker.stories.ts
driskull Feb 12, 2026
66fe85b
Merge branch 'dev' into dris0000/date-picker-month-header-scale
driskull Feb 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions packages/components/src/components/date-picker-month-header/date-picker-month-header.e2e.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,4 +66,18 @@ describe("calcite-date-picker-month-header", () => {
const yearInput = await page.find(`calcite-date-picker-month-header >>> input`);
expect(yearInput.getAttribute("aria-label")).toBe(messages.year);
});

it("displays the correct scale for actions", async () => {
Copy link
Member

@jcfranco jcfranco Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you try adding this as a browser test instead? We should prioritize browser mode for new tests to help move away from Puppeteer E2E tests.

This can be done as a follow up.

const datePickerMonthHeader = await page.find("calcite-date-picker-month-header");
const [prev, next] = await findAll(page, "calcite-date-picker-month-header >>> .chevron");

const scales = ["s", "m", "l"] as const;

for (const scale of scales) {
datePickerMonthHeader.setProperty("scale", scale);
await page.waitForChanges();
expect(await prev.getProperty("scale")).toBe(scale);
expect(await next.getProperty("scale")).toBe(scale);
}
});
});
2 changes: 1 addition & 1 deletion packages/components/src/components/date-picker-month-header/date-picker-month-header.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -524,7 +524,7 @@ export class DatePickerMonthHeader extends LitElement {
onKeyDown={isDirectionRight ? this.nextMonthKeydown : this.prevMonthKeydown}
ref={isDirectionRight ? this.nextMonthActionRef : this.prevMonthActionRef}
role="button"
scale={this.scale === "l" ? "l" : "m"}
scale={this.scale}
text={isDirectionRight ? this.messages.nextMonth : this.messages.prevMonth}
/>
);
Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/components/date-picker/date-picker.stories.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,7 +208,7 @@ localized.parameters = {
};

export const widthSetToBreakpoints_TestOnly = (): string =>
createBreakpointStories(html`<calcite-date-picker scale="{scale}" value="2000-11-27"></calcite-date-picker>`);
createBreakpointStories(html`<calcite-date-picker scale="s" value="2000-11-27"></calcite-date-picker>`);

export const defaultWidthAllScales_TestOnly = (): string => html`
<calcite-date-picker scale="s" value="2000-11-27"></calcite-date-picker>
Expand Down
Loading