Calibration: Add source names for detector modules (using source_name_pattern)#146
Open
takluyver wants to merge 4 commits into
Open
Calibration: Add source names for detector modules (using source_name_pattern)#146takluyver wants to merge 4 commits into
takluyver wants to merge 4 commits into
Conversation
Collaborator
|
Looks like this MR got forgotten, and there are conflicts now as well. This is not even counting Shall we still try to get this in first? |
Member
Author
|
I think at this point we may as well get DetectorData in first - maybe leaving out the bits that work with source names - and then rebase this. |
Merged
Collaborator
|
This has been merged as part of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CalCat now allows specifying a source_name_pattern for detectors, such as
'HED_DET_AGIPD65K1/DET/{modno+8}CH0:xtdf'. With this, we can expose source names as yet another way to describe detector modules.