Fix: Remove unmatched PHPStan ignore comments in BaseMap.php#106
Merged
Conversation
PHPStan is reporting "No error with identifier assign.propertyType is reported" errors on lines 170, 174, 223, and 273 because the @phpstan-ignore comments are no longer necessary. These ignore directives are for the `assign.propertyType` error, but the code no longer triggers this error. Removed the unmatched ignore comments to resolve the PHPStan errors.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #106 +/- ##
=========================================
Coverage 97.68% 97.68%
Complexity 220 220
=========================================
Files 9 9
Lines 519 519
=========================================
Hits 507 507
Misses 12 12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
PHPStan is reporting "No error with identifier assign.propertyType is reported" errors on lines 170, 174, 223, and 273 because the @phpstan-ignore comments are no longer necessary. These ignore directives are for the `assign.propertyType` error, but the code no longer triggers this error. Kept the valid ignore comments on lines 78, 209, 214, and 228 which are still needed. Removed only the unmatched ignore comments to resolve the PHPStan errors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.