Skip to content

Fix: Remove unmatched PHPStan ignore comments in BaseMap.php #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mondrake merged 2 commits into from
May 13, 2026
Merged

Fix: Remove unmatched PHPStan ignore comments in BaseMap.php #106

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
81a228e
Fix: Remove unmatched PHPStan ignore comments in BaseMap.php
mondrake May 13, 2026
307f3d5
Fix: Remove unmatched PHPStan ignore comments in BaseMap.php
mondrake May 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions src/Map/BaseMap.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,11 +166,9 @@ protected function getMapSubEntry(string $entry, string $entryKey, string $subEn
protected function addMapSubEntry(string $entry, string $entryKey, string $subEntry, string $value): MapInterface
{
if (!isset(static::$map[$entry][$entryKey][$subEntry])) {
// @phpstan-ignore assign.propertyType
static::$map[$entry][$entryKey][$subEntry] = [$value];
} else {
if (array_search($value, static::$map[$entry][$entryKey][$subEntry]) === false) {
// @phpstan-ignore assign.propertyType
static::$map[$entry][$entryKey][$subEntry][] = $value;
}
}
Expand Down Expand Up @@ -219,7 +217,6 @@ protected function removeMapSubEntry(string $entry, string $entryKey, string $su
foreach (static::$map[$entry][$entryKey][$subEntry] as $v) {
$tmp[] = $v;
}
// @phpstan-ignore assign.propertyType
static::$map[$entry][$entryKey][$subEntry] = $tmp;
}

Expand Down Expand Up @@ -269,7 +266,6 @@ protected function setValueAsDefault(string $entry, string $entryKey, string $su
}
$tmp[] = $v;
}
// @phpstan-ignore assign.propertyType
static::$map[$entry][$entryKey][$subEntry] = $tmp;

return $this;
Expand Down
Loading