This repository was archived by the owner on Mar 17, 2025. It is now read-only.
move modem and things to contrib dir #241
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping @ed7coyne ? |
ed7coyne
reviewed
Jan 13, 2017
| FBASE_NOAUTH_SNIPPET=test/travis/no_firebase_init.cc.snip | ||
| FBASE_NOCONFIG_SNIPPET=test/travis/no_config_init.cc.snip | ||
| for example in `find examples/ -name *.ino`; | ||
| FBASE_SNIPPET=contrib/test/travis/firebase_init.cc.snip |
There was a problem hiding this comment.
Should this test be in contrib? It seems part of the main project.
There was a problem hiding this comment.
I meant this to be a file-comment, it is the entire script that seems part of the core project.
There was a problem hiding this comment.
IIRC I moved all the tests stuff to contrib/ for now, since it was pretty tangled.
So that we can easily package the Arduino library as: root - everything in contrib until we find a better organization/packaging option.
There was a problem hiding this comment.
ah I see, sounds like a good plan.
|
Mostly LGTM, I think this clears up the distinction between the primary project and the derivative projects pretty well, thanks! |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's see if travis build this :)
Fixes #240 #118 #92