This repository was archived by the owner on Mar 17, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 492
move modem and things to contrib dir #241
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
[submodule "test/googletest"] | ||
path = test/googletest | ||
[submodule "contrib/test/googletest"] | ||
path = contrib/test/googletest | ||
url = https://github.com/google/googletest.git | ||
[submodule "test/arduino-mock"] | ||
path = test/arduino-mock | ||
[submodule "contrib/test/arduino-mock"] | ||
path = contrib/test/arduino-mock | ||
url = https://github.com/ed7coyne/arduino-mock.git |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
# firebase-arduino contrib | ||
|
||
The `contrib` features projects around `firebase-arduino` library: | ||
|
||
- `modem`: a firmware implementing a `UART` modem for firebase | ||
- `firethings`: a firmware implementing `GPIO` state syncing with firebase | ||
- `hardware`: hardware design for `ESP8266` reference boards | ||
- `test`: test suite and mocks |
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
Submodule arduino-mock
added at
0f7f9f
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
Submodule googletest
added at
a2b8a8
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
10 changes: 5 additions & 5 deletions
10
...s/check_all_examples_use_standard_init.sh → ...s/check_all_examples_use_standard_init.sh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,16 +1,16 @@ | ||
#!/bin/bash | ||
FBASE_SNIPPET=test/travis/firebase_init.cc.snip | ||
FBASE_NOAUTH_SNIPPET=test/travis/no_firebase_init.cc.snip | ||
FBASE_NOCONFIG_SNIPPET=test/travis/no_config_init.cc.snip | ||
for example in `find examples/ -name *.ino`; | ||
FBASE_SNIPPET=contrib/test/travis/firebase_init.cc.snip | ||
FBASE_NOAUTH_SNIPPET=contrib/test/travis/no_firebase_init.cc.snip | ||
FBASE_NOCONFIG_SNIPPET=contrib/test/travis/no_config_init.cc.snip | ||
for example in `find examples/ contrib/examples/ -name *.ino`; | ||
do | ||
echo $example; | ||
(xxd -p $example | tr -d '\n' | grep -q `xxd -p $FBASE_SNIPPET | tr -d '\n'`) || | ||
(xxd -p $example | tr -d '\n' | grep -q `xxd -p $FBASE_NOAUTH_SNIPPET | tr -d '\n'`) || | ||
(xxd -p $example | tr -d '\n' | grep -q `xxd -p $FBASE_NOCONFIG_SNIPPET | tr -d '\n'`) || | ||
if [ $? -ne 0 ]; | ||
then | ||
echo $example does not contain standard defined in test/travis/*_init.cc.snip. | ||
echo $example does not contain standard defined in contrib/test/travis/*_init.cc.snip. | ||
exit 1; | ||
fi; | ||
done; |
File renamed without changes.
File renamed without changes.
File renamed without changes.
Submodule arduino-mock
deleted from
ff0f89
Submodule googletest
deleted from
ff07a5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this test be in contrib? It seems part of the main project.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I meant this to be a file-comment, it is the entire script that seems part of the core project.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IIRC I moved all the tests stuff to contrib/ for now, since it was pretty tangled.
So that we can easily package the Arduino library as: root - everything in contrib until we find a better organization/packaging option.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah I see, sounds like a good plan.