-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: improve parity between shelf and flutter #983
Open
mcquenji
wants to merge
14
commits into
Flutterando:master
Choose a base branch
from
necodeIT:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
change-logical-check-WebUrlService
* Fix: Pop child routes when parent route is popped * + Added unit test for parent/child route handling --------- Co-authored-by: zssnyder <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to make modules written with
modular_core
to work in shelf and flutter.Also has #963 merged.
Routing Mechanism Improvements:
shelf_modular/lib/src/presenter/extensions/route_manage_extension.dart
: Added aname
parameter to theresource
method to allow named routes.shelf_modular/lib/src/presenter/models/route.dart
: Updated theRoute.resource
factory to include aname
parameter and utilize theRouteManager
for managing child routes.shelf_modular/lib/src/presenter/resources/resource.dart
: Changed theroutes
method in theResource
class to accept aRouteManager
parameter instead of returning a list of routes.Class Enhancements:
modular_core/lib/src/route/route.dart
: Added atoString
method to theModularKey
class for better debugging and logging.shelf_modular/lib/src/presenter/modular_base.dart
: Added a check to return an empty map if the request data is empty in theModularBase
class.These changes collectively enhance the routing capabilities, ensure compatibility with the latest dependencies, and improve the overall code quality and maintainability.
Checklist
fix:
,feat:
,docs:
etc).docs
and added dartdoc comments with///
.examples
.Breaking Change
shelf_modular
now uses the same builder methods for binds instead of a getter.Related Issues
#963
#968