Do not enter local scopes in python #1982
Conversation
KuechA
requested review from
peckto,
maximiliankaul and
lshala
as code owners
Codecov ReportAttention: Patch coverage is
❌ Your patch status has failed because the patch coverage (50.00%) is below the target coverage (75.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Whoop Whoop. I adjusted the "failing" tests, they still were under the assumption that the local scope exists. This was bugging me for so long and we could finally got rid of the local scopes - also thanks to the EOG rework of @konradweiss
I will leave this unmerged until @maximiliankaul has a chance to look at it.
...language-python/src/main/kotlin/de/fraunhofer/aisec/cpg/frontends/python/StatementHandler.kt
Show resolved
Hide resolved
...nguage-python/src/test/kotlin/de/fraunhofer/aisec/cpg/frontends/python/PythonFrontendTest.kt
Show resolved
Hide resolved
...language-python/src/main/kotlin/de/fraunhofer/aisec/cpg/frontends/python/StatementHandler.kt
Show resolved
Hide resolved
* Do not enter local scopes in python * Revert wronge change * Fixed testGlobal * Fixed testVarsAndFields * Fixed testNonLocal --------- Co-authored-by: Christian Banse <[email protected]>
Python function declarations somehow enter a
LocalScopewhich doesn't make sense. This feature is no longer needed by the graph and was there for legacy reasons. Also lead to incorrect lookups of variables. After this PR, python does no longer enter theseLocalScopes . Since the feature was error-prone and only used in a single place (no not at all any more), it's removed completely.Fixes #1978