Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENCHANCEMENT] Additional Functionality for Playbars (Assets) #132

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

[ENCHANCEMENT] Additional Functionality for Playbars (Assets) #132

wants to merge 5 commits into from

Conversation

Trofem
Copy link

@Trofem Trofem commented Feb 26, 2025 •
edited
Loading

This PR changed playbar.xml file. Now it describes changed logic of playbars, accordingly to #4229 Funkin PR changes.

  • Difficulty:
    image 1

  • BPM:
    image 2

  • Note Snap
    image 3

  • Song Remaining Time:
    image 4

@Trofem
updated playbar labels.
2caed4c 
For playbarDifficulty and playbarBPM added /close description.
Closing/openning ability added to all other buttons in this order:
playbarNoteSnap - Ctrl+Click -> Note Window.
playbarSongRemaining - Click -> Offsets Window
I think this is optimal!
@Trofem
extended tooltip to playbarSongRemaining
a879505 
tooltip="Song Remaining Time/Left Click to open/close Offsets Window"
@Trofem
typo
c5d3d58 
\n added and etc
@Trofem
wrong symbol
32b8028
@Trofem
another typo
8d78bb9 
i hope this is final change for now.
@Trofem Trofem mentioned this pull request Feb 26, 2025
Open
@Hundrec Hundrec added chart editor PR is related to the operation of the Chart Editor. status: pending triage The bug or PR has not been reviewed yet. size: small A small pull request with 10 or fewer changes labels Feb 26, 2025
@AbnormalPoof AbnormalPoof added type: enhancement Provides an enhancement or new feature. status: pending pull request Has a PR which resolves it that is pending review. and removed status: pending triage The bug or PR has not been reviewed yet. labels Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
chart editor PR is related to the operation of the Chart Editor. size: small A small pull request with 10 or fewer changes status: pending pull request Has a PR which resolves it that is pending review. type: enhancement Provides an enhancement or new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Trofem @AbnormalPoof @Hundrec