Make aircraft tail arrays allocatable so that max_tail can be set from a namelist entry #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in tails due to addition of ADS-C data from non-U.S. aircraft to the input data stream. ESMA (progress) ticket #2454
'max_tail' value can be set via namelist
|
Label error. Requires at least 1 of: 0 diff, 0 diff trivial, Non 0-diff, 0 diff structural, 0-diff trivial, Not 0-diff, 0-diff, automatic, 0-diff uncoupled. Found: |
gmao-msienkie
added
the
0 diff
rtodling
approved these changes
Dec 12, 2024
gmao-msienkie
deleted the
feature/msienkie/aircraft_max_tail_from_namelist
branch
|
The changes look fine to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently our input aircraft data stream has been receiving additional data - an increase in MDCRS data, and the addition of ADS-C AMDAR data. This has also led to an increase in the number of entries in the aircraft bias coefficient arrays as the number of unique tail identifiers increases. Since the beginning of November the number of entries in the abias_air file has increased from around 10000 to more than 12500. If the entries continue to increase we will need to keep recompiling the GSI to increase the size of the arrays associated with the bias correction.
If the bias coefficient arrays are changed to be allocatable, then we can add a namelist variable to specify the size of max_tail which is the size of the bias coefficient arrays. This is an implementation of the idea.
I added the namelist variable 'max_tail' to the OBSQC namelist because that is where the other settings for aircraft bias are located. However the radiance VarBC settings are under the SETUP namelist and it is not clear why the aircraft bias settings should be under OBSQC though I guess it doesn't really matter.