Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make aircraft tail arrays allocatable so that max_tail can be set from a namelist entry #190

Merged
merged 4 commits into from
Dec 12, 2024
Merged

Make aircraft tail arrays allocatable so that max_tail can be set from a namelist entry #190

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7f6fb14
Increase max_tail buffer size for aircraft to accomodate increase
gmao-msienkie Nov 7, 2024
a20f164
Make arrays dimensioned by 'max_tail' allocatable so that the
gmao-msienkie Dec 11, 2024
9f2d694
add sample entry for max_tail to template files
gmao-msienkie Dec 11, 2024
0fb8774
Merge branch 'develop' into feature/msienkie/aircraft_max_tail_from_n…
gmao-msienkie Dec 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 28 additions & 18 deletions GEOSaana_GridComp/GSI_GridComp/aircraftinfo.f90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,19 +55,19 @@ module aircraftinfo
logical :: aircraft_t_bc_ext ! logical to turn off or on the externally supplied aircraft bias correction
logical :: cleanup_tail ! logical to remove tail number no longer used
logical :: upd_aircraft ! indicator if update bias at 06Z & 18Z
integer(i_kind), parameter :: max_tail=15000 ! max tail numbers

integer(i_kind) max_tail ! max tail numbers
integer(i_kind) npredt ! predictor number
integer(i_kind) ntail ! total tail number
integer(i_kind) ntail_update ! new total tail number
integer(i_kind) mype_airobst ! processor reading in aircraft profile data
integer(i_kind) mype_airobst ! processor reading in aircraft profile data
integer(i_kind) nsort ! used in sorting tail number
character(len=10),dimension(max_tail):: taillist ! tail number
character(len=1),dimension(max_tail):: itail_sort ! used in sorting tail number
integer(i_kind),dimension(max_tail):: idx_tail ! index of tail
integer(i_kind),dimension(max_tail):: idx_sort ! used in sorting tail number
integer(i_kind),dimension(max_tail):: timelist ! time stamp

character(len=10),allocatable,dimension(:):: taillist ! tail number
character(len=1),allocatable,dimension(:):: itail_sort ! used in sorting tail number
integer(i_kind),allocatable,dimension(:):: idx_tail ! index of tail
integer(i_kind),allocatable,dimension(:):: idx_sort ! used in sorting tail number
integer(i_kind),allocatable,dimension(:):: timelist ! time stamp
real(r_kind):: biaspredt ! berror var for temperature bias correction coefficients
real(r_kind):: upd_pred_t ! =1 update bias; =0 no update
real(r_kind):: hdist_aircraft ! horizontal distance threshold for errormod_aircraft
Expand All @@ -94,6 +94,8 @@ subroutine init_aircraft
! program history log:
! 2013-05-17 Zhu
! 2014-03-04 Sienkiewicz - added aircraft_t_bc_ext option
! 2024-12-10 Sienkiewicz - arrays dimensioned by 'max_tail' changed to
! allocatable arrays so 'max_tail' can be set via a namelist
!
! input argument list:
!
Expand All @@ -115,14 +117,16 @@ subroutine init_aircraft
aircraft_t_bc = .false. ! .true.=turn on bias correction
aircraft_t_bc_pof = .false. ! .true.=turn on bias correction
aircraft_t_bc_ext = .false. ! .true.=turn on bias correction
cleanup_tail = .false. ! no removal of tail number
cleanup_tail = .false. ! no removal of tail number
mype_airobst = 0

upd_aircraft=.true.
upd_pred_t=one

hdist_aircraft=60000.0_r_kind

max_tail = 20000

end subroutine init_aircraft


Expand Down Expand Up @@ -176,7 +180,7 @@ subroutine aircraftinfo_read
if(verbose .and. mype == 0)print_verbose=.true.
! Determine number of entries in aircraft bias file
inquire(file='aircftbias_in',exist=pcexist)
if (.not. pcexist) then
if (.not. pcexist) then
write(6,*)'AIRCRAFTINFO_READ: ***ERROR*** aircftbias_in not found'
call stop2(340)
end if
Expand Down Expand Up @@ -204,7 +208,7 @@ subroutine aircraftinfo_read
write(6,120) ntail
120 format('AIRCRAFTINFO_READ: ntail=',1x,i6)
endif
if (ntail > max_tail) then
if (ntail > max_tail) then
write(6,*)'AIRCRAFTINFO_READ: ***ERROR*** ntail exceeds max_tail'
write(6,*)'AIRCRAFTINFO_READ: stop program execution'
call stop2(340)
Expand All @@ -221,6 +225,9 @@ subroutine aircraftinfo_read
ostats_t = zero_quad
rstats_t = zero_quad

allocate(taillist(max_tail),itail_sort(max_tail),idx_tail(max_tail), &
idx_sort(max_tail),timelist(max_tail))

j=0
do k=1,nlines
read(lunin,100) cflg,crecord
Expand All @@ -241,7 +248,7 @@ subroutine aircraftinfo_read
110 format(a10,1x,i5,9(1x,f12.6),1x,i8)

! Do not update aircraft temperature bias at 6Z and 18Z
if (.not. upd_aircraft) then
if (.not. upd_aircraft) then
anal_time = iadate(4)
if (anal_time==6 .or. anal_time==18) upd_pred_t = zero
if (mype==0) print*, 'aircraft_info anal_time upd_pred_t=', anal_time, upd_pred_t
Expand All @@ -258,7 +265,7 @@ subroutine aircraftinfo_read
itail_sort(isort) = cb
idx_sort(isort) = k
cb0 = cb
end if
end if
end do
nsort = isort
if (mype==0) print*, 'nsort = ', nsort
Expand All @@ -279,6 +286,8 @@ subroutine aircraftinfo_write
!
! program history log:
! 2013-05-17 Yanqiu Zhu
! 2024-12-10 Sienkiewicz - arrays dimensioned by 'max_tail' changed to
! allocatable arrays so 'max_tail' can be set via a namelist
!
! input argument list:
!
Expand Down Expand Up @@ -327,13 +336,13 @@ subroutine aircraftinfo_write
end do
do i=1,ntail_update
csort(i) = taillist(i)
end do
end do
! cleanup tailnumber in the aircraft bias file
obsolete = 0
if (cleanup_tail) then
iyyyymm = iadate(1)*100+iadate(2)
do i=1,ntail_update
if (abs(iyyyymm-timelist(i))>=100) then
if (abs(iyyyymm-timelist(i))>=100) then
csort(i) = 'zzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzz'
obsolete = obsolete+1
end if
Expand All @@ -349,6 +358,7 @@ subroutine aircraftinfo_write
end do

close(lunout)
deallocate(taillist,itail_sort,idx_tail,idx_sort,timelist)
deallocate(predt)
deallocate(ostats_t,rstats_t,varA_t)

Expand Down Expand Up @@ -420,7 +430,7 @@ subroutine indexc40(n,carrin,indx)
l = n/2 + 1
ir = n

do
do
if(l.gt.1) then
l = l - 1
indxt = indx(l)
Expand All @@ -439,7 +449,7 @@ subroutine indexc40(n,carrin,indx)
i = l
j = l * 2

do
do
if(j.le.ir) then
if(j.lt.ir) then
if(carrin(indx(j)).lt.carrin(indx(j+1))) j = j + 1
Expand Down
2 changes: 1 addition & 1 deletion GEOSaana_GridComp/GSI_GridComp/etc/gsi.rc.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@
&OBSQC
dfact=0.75,dfact1=3.0,noiqc=.false.,oberrflg=.true.,c_varqc=0.02,blacklst=.true.,
use_poq7=.true.,qc_noirjaco3=.false.,qc_satwnds=.false.,cld_det_dec2bin=.true.,
half_goesr_err=.false.,
half_goesr_err=.false.,max_tail=15000,
! tcp_ermin=0.75,tcp_ermax=0.75,
>>>AIRCFT_BIAS<<<
/
Expand Down
6 changes: 3 additions & 3 deletions GEOSaana_GridComp/GSI_GridComp/etc/gsi_fdda_1.rc.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,16 +61,16 @@
&OBSQC
dfact=0.75,dfact1=3.0,noiqc=.false.,oberrflg=.true.,c_varqc=0.02,blacklst=.true.,
use_poq7=.true.,qc_noirjaco3=.false.,qc_satwnds=.false.,cld_det_dec2bin=.true.,
half_goesr_err=.false.,
half_goesr_err=.false.,max_tail=15000,
! tcp_ermin=0.75,tcp_ermax=0.75,
>>>AIRCFT_BIAS<<<
/
&OBS_INPUT
dmesh(1)=145.0,dmesh(2)=150.0,dmesh(3)=180.0,time_window_max=3.0,
dmesh(1)=145.0,dmesh(2)=150.0,dmesh(3)=180.0,time_window_max=3.0,
/
OBS_INPUT::
! dfile dtype dplat dsis dval dthin dsfcalc obsclass
prepbufr ps null ps 0.0 0 0 ncep_prep_bufr
prepbufr ps null ps 0.0 0 0 ncep_prep_bufr
prepbufr t null t 0.0 0 0 ncep_prep_bufr
prepbufr_profl t null t 0.0 0 0 ncep_acftpfl_bufr
prepbufr q null q 0.0 0 0 ncep_prep_bufr
Expand Down
6 changes: 3 additions & 3 deletions GEOSaana_GridComp/GSI_GridComp/etc/gsi_fdda_2.rc.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,16 +61,16 @@
&OBSQC
dfact=0.75,dfact1=3.0,noiqc=.false.,oberrflg=.true.,c_varqc=0.02,blacklst=.true.,
use_poq7=.true.,qc_noirjaco3=.false.,qc_satwnds=.false.,cld_det_dec2bin=.true.,
half_goesr_err=.false.,
half_goesr_err=.false.,max_tail=15000,
! tcp_ermin=0.75,tcp_ermax=0.75,
>>>AIRCFT_BIAS<<<
/
&OBS_INPUT
dmesh(1)=145.0,dmesh(2)=150.0,dmesh(3)=180.0,time_window_max=3.0,
dmesh(1)=145.0,dmesh(2)=150.0,dmesh(3)=180.0,time_window_max=3.0,
/
OBS_INPUT::
! dfile dtype dplat dsis dval dthin dsfcalc obsclass
prepbufr ps null ps 0.0 0 0 ncep_prep_bufr
prepbufr ps null ps 0.0 0 0 ncep_prep_bufr
prepbufr t null t 0.0 0 0 ncep_prep_bufr
prepbufr_profl t null t 0.0 0 0 ncep_acftpfl_bufr
prepbufr q null q 0.0 0 0 ncep_prep_bufr
Expand Down
6 changes: 3 additions & 3 deletions GEOSaana_GridComp/GSI_GridComp/etc/gsi_fgat_1.rc.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,16 +59,16 @@
&OBSQC
dfact=0.75,dfact1=3.0,noiqc=.false.,oberrflg=.true.,c_varqc=0.02,blacklst=.true.,
use_poq7=.true.,qc_noirjaco3=.false.,qc_satwnds=.false.,cld_det_dec2bin=.true.,
half_goesr_err=.false.,
half_goesr_err=.false.,max_tail=15000,
! tcp_ermin=0.75,tcp_ermax=0.75,
>>>AIRCFT_BIAS<<<
/
&OBS_INPUT
dmesh(1)=145.0,dmesh(2)=150.0,dmesh(3)=180.0,time_window_max=3.0,
dmesh(1)=145.0,dmesh(2)=150.0,dmesh(3)=180.0,time_window_max=3.0,
/
OBS_INPUT::
! dfile dtype dplat dsis dval dthin dsfcalc obsclass
prepbufr ps null ps 0.0 0 0 ncep_prep_bufr
prepbufr ps null ps 0.0 0 0 ncep_prep_bufr
prepbufr t null t 0.0 0 0 ncep_prep_bufr
prepbufr_profl t null t 0.0 0 0 ncep_acftpfl_bufr
prepbufr q null q 0.0 0 0 ncep_prep_bufr
Expand Down
6 changes: 3 additions & 3 deletions GEOSaana_GridComp/GSI_GridComp/etc/gsi_fgat_2.rc.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,16 +59,16 @@
&OBSQC
dfact=0.75,dfact1=3.0,noiqc=.false.,oberrflg=.true.,c_varqc=0.02,blacklst=.true.,
use_poq7=.true.,qc_noirjaco3=.false.,qc_satwnds=.false.,cld_det_dec2bin=.true.,
half_goesr_err=.false.,
half_goesr_err=.false.,max_tail=15000,
! tcp_ermin=0.75,tcp_ermax=0.75,
>>>AIRCFT_BIAS<<<
/
&OBS_INPUT
dmesh(1)=145.0,dmesh(2)=150.0,dmesh(3)=180.0,time_window_max=3.0,
dmesh(1)=145.0,dmesh(2)=150.0,dmesh(3)=180.0,time_window_max=3.0,
/
OBS_INPUT::
! dfile dtype dplat dsis dval dthin dsfcalc obsclass
prepbufr ps null ps 0.0 0 0 ncep_prep_bufr
prepbufr ps null ps 0.0 0 0 ncep_prep_bufr
prepbufr t null t 0.0 0 0 ncep_prep_bufr
prepbufr_profl t null t 0.0 0 0 ncep_acftpfl_bufr
prepbufr q null q 0.0 0 0 ncep_prep_bufr
Expand Down
2 changes: 1 addition & 1 deletion GEOSaana_GridComp/GSI_GridComp/etc/gsi_sens.rc.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@
&OBSQC
dfact=0.75,dfact1=3.0,noiqc=.false.,oberrflg=.true.,c_varqc=0.02,blacklst=.true.,
use_poq7=.true.,qc_noirjaco3=.false.,qc_satwnds=.false.,cld_det_dec2bin=.true.,
half_goesr_err=.false.,
half_goesr_err=.false.,max_tail=15000,
! tcp_ermin=0.75,tcp_ermax=0.75,
>>>AIRCFT_BIAS<<<
/
Expand Down
6 changes: 3 additions & 3 deletions GEOSaana_GridComp/GSI_GridComp/etc/obs.rc.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,16 +58,16 @@
&OBSQC
dfact=0.75,dfact1=3.0,noiqc=.false.,oberrflg=.true.,c_varqc=0.02,blacklst=.true.,
use_poq7=.true.,qc_noirjaco3=.false.,qc_satwnds=.false.,cld_det_dec2bin=.true.,
half_goesr_err=.false.,
half_goesr_err=.false.,max_tail=15000,
! tcp_ermin=0.75,tcp_ermax=0.75,
>>>AIRCFT_BIAS<<<
/
&OBS_INPUT
dmesh(1)=145.0,dmesh(2)=150.0,dmesh(3)=180.0,time_window_max=3.0,
dmesh(1)=145.0,dmesh(2)=150.0,dmesh(3)=180.0,time_window_max=3.0,
/
OBS_INPUT::
! dfile dtype dplat dsis dval dthin dsfcalc obsclass
prepbufr ps null ps 0.0 0 0 ncep_prep_bufr
prepbufr ps null ps 0.0 0 0 ncep_prep_bufr
prepbufr t null t 0.0 0 0 ncep_prep_bufr
prepbufr_profl t null t 0.0 0 0 ncep_acftpfl_bufr
prepbufr q null q 0.0 0 0 ncep_prep_bufr
Expand Down
Loading
Loading