Updating libgit2sharp binaries (removes curl/zlib dependency) #1544
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah, it looks like https://github.com/GitTools/GitTools.Core needs to be updated. I'll look into that. |
|
It looks like the latest libgit2sharp uses netstandard2.0 and net461. This would affect both GitTools.Core and this repo. Is this a no go? Would you guys want to drop netstandard1.3, net40, net45, etc? |
|
See #1422 |
|
@pauldotknopf, thanks fort this! I assume #1422 will change the prerequisites for your work here so perhaps wait until that's merged, rebase and move from there? |
|
Yup, I'll wait. |
Closed
|
In order for this to work, we'd have to drop net461 and target only netstandard. |
|
Actually, it looks like it was already done. Sweet! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See this and this.
Using
gitversionon Ubuntu 18.10 currently is broken (because of libcurl4). Updating to this version of the libgit2sharp native binaries should resolve my issue.