Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Updating the node environment to Node.js 20 #3617

Merged
merged 25 commits into from
Apr 16, 2024
Merged

Conversation

iennae
Copy link
Contributor

@iennae iennae commented Jan 26, 2024

Description

updates some region tags, updates node environment

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • [] Tests pass: npm test (see Testing)
  • [] Lint pass: npm run lint (see Style)
  • This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
  • Please merge this PR for me once it is approved

I verified that the changes worked (region tags don't impact deployment)

@iennae iennae requested review from a team as code owners January 26, 2024 20:25
Copy link

snippet-bot bot commented Jan 26, 2024

Here is the summary of changes.

You are about to add 6 region tags.
You are about to delete 5 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added samples Issues that are directly related to samples. api: appengine Issues related to the App Engine Admin API API. asset: pattern DEE Asset tagging - Pattern. labels Jan 26, 2024
Signed-off-by: Jennifer Davis <[email protected]>
@engelke engelke assigned engelke and pattishin and unassigned engelke Jan 26, 2024
@pattishin
Copy link
Contributor

/gcbrun

Copy link
Contributor

@pattishin pattishin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @iennae! 👍🏼 Added a few comments based from snippet-bot and header-check.

appengine/building-an-app/build/server.js Show resolved Hide resolved
appengine/building-an-app/build/server.js Outdated Show resolved Hide resolved
appengine/building-an-app/update/server.js Outdated Show resolved Hide resolved
@iennae iennae added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 16, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 16, 2024
@iennae iennae added kokoro:force-run Add this label to force Kokoro to re-run the tests. snippet-bot:force-run Force snippet-bot runs its logic labels Apr 16, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 16, 2024
@snippet-bot snippet-bot bot removed the snippet-bot:force-run Force snippet-bot runs its logic label Apr 16, 2024
@iennae iennae added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 16, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 16, 2024
@iennae iennae added the snippet-bot:force-run Force snippet-bot runs its logic label Apr 16, 2024
@snippet-bot snippet-bot bot removed the snippet-bot:force-run Force snippet-bot runs its logic label Apr 16, 2024
@iennae iennae requested a review from pattishin April 16, 2024 19:50
@iennae iennae merged commit 4f5a7fe into main Apr 16, 2024
34 checks passed
@iennae iennae deleted the fix_updating_node_env branch April 16, 2024 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: appengine Issues related to the App Engine Admin API API. asset: pattern DEE Asset tagging - Pattern. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants