Skip to content

Comments

feat: batch_labels_allocation#3785

Merged
subfuzion merged 5 commits intomainfrom
batch-labels-allocation
Aug 12, 2024
Merged

feat: batch_labels_allocation#3785
subfuzion merged 5 commits intomainfrom
batch-labels-allocation

Conversation

@gryczj
Copy link
Contributor

@gryczj gryczj commented Aug 9, 2024

Description

Fixes #

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • Tests pass: npm test (see Testing)
  • Lint pass: npm run lint (see Style)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@gryczj gryczj added kokoro:force-run Add this label to force Kokoro to re-run the tests. samples Issues that are directly related to samples. api: batch Issues related to the Batch API. labels Aug 9, 2024
@gryczj gryczj self-assigned this Aug 9, 2024
@gryczj gryczj requested review from a team as code owners August 9, 2024 20:54
@snippet-bot
Copy link

snippet-bot bot commented Aug 9, 2024

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 9, 2024
@gryczj gryczj added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels Aug 9, 2024
@kokoro-team kokoro-team removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Aug 9, 2024
@gryczj gryczj force-pushed the batch-labels-allocation branch from 6ca4d9e to 5d0a040 Compare August 9, 2024 20:54
@@ -0,0 +1,125 @@
/*
* Copyright 2021 Google LLC
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a new sample but copying an older header. please make sure samples that are new have 2024

@subfuzion subfuzion merged commit c3d2dc7 into main Aug 12, 2024
@subfuzion subfuzion deleted the batch-labels-allocation branch August 12, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: batch Issues related to the Batch API. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants