-
Notifications
You must be signed in to change notification settings - Fork 2k
feat: batch_labels_allocation #3785
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
5d0a040
feat: batch_labels_allocation
2bb10b6
Merge branch 'main' into batch-labels-allocation
subfuzion 27f3c1b
Merge remote-tracking branch 'origin/main' into batch-labels-allocation
subfuzion 339ae77
chore: update copyright year
subfuzion 3e6af0b
Merge branch 'main' into batch-labels-allocation
subfuzion File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,125 @@ | ||
| /* | ||
| * Copyright 2021 Google LLC | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * https://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| 'use strict'; | ||
|
|
||
| async function main() { | ||
| // [START batch_labels_allocation] | ||
| // Imports the Batch library | ||
| const batchLib = require('@google-cloud/batch'); | ||
| const batch = batchLib.protos.google.cloud.batch.v1; | ||
|
|
||
| // Instantiates a client | ||
| const batchClient = new batchLib.v1.BatchServiceClient(); | ||
|
|
||
| /** | ||
| * TODO(developer): Update these variables before running the sample. | ||
| */ | ||
| const projectId = await batchClient.getProjectId(); | ||
| // Name of the region you want to use to run the job. Regions that are | ||
| // available for Batch are listed on: https://cloud.google.com/batch/docs/get-started#locations | ||
| const region = 'europe-central2'; | ||
| // The name of the job that will be created. | ||
| // It needs to be unique for each project and region pair. | ||
| const jobName = 'batch-labels-allocation-job'; | ||
| // Name of the label1 to be applied for your Job. | ||
| const labelName1 = 'vm_label_name_1'; | ||
| // Value for the label1 to be applied for your Job. | ||
| const labelValue1 = 'vmLabelValue1'; | ||
| // Name of the label2 to be applied for your Job. | ||
| const labelName2 = 'vm_label_name_2'; | ||
| // Value for the label2 to be applied for your Job. | ||
| const labelValue2 = 'vmLabelValue2'; | ||
|
|
||
| // Define what will be done as part of the job. | ||
| const runnable = new batch.Runnable({ | ||
| script: new batch.Runnable.Script({ | ||
| commands: ['-c', 'echo Hello world! This is task ${BATCH_TASK_INDEX}.'], | ||
| }), | ||
| }); | ||
|
|
||
| // Specify what resources are requested by each task. | ||
| const computeResource = new batch.ComputeResource({ | ||
| // In milliseconds per cpu-second. This means the task requires 50% of a single CPUs. | ||
| cpuMilli: 500, | ||
| // In MiB. | ||
| memoryMib: 16, | ||
| }); | ||
|
|
||
| const task = new batch.TaskSpec({ | ||
| runnables: [runnable], | ||
| computeResource, | ||
| maxRetryCount: 2, | ||
| maxRunDuration: {seconds: 3600}, | ||
| }); | ||
|
|
||
| // Tasks are grouped inside a job using TaskGroups. | ||
| const group = new batch.TaskGroup({ | ||
| taskCount: 3, | ||
| taskSpec: task, | ||
| }); | ||
|
|
||
| // Policies are used to define on what kind of virtual machines the tasks will run on. | ||
| // In this case, we tell the system to use "e2-standard-4" machine type. | ||
| // Read more about machine types here: https://cloud.google.com/compute/docs/machine-types | ||
| const instancePolicy = new batch.AllocationPolicy.InstancePolicy({ | ||
| machineType: 'e2-standard-4', | ||
| }); | ||
|
|
||
| const allocationPolicy = new batch.AllocationPolicy({ | ||
| instances: [{policy: instancePolicy}], | ||
| }); | ||
| // Labels and their value to be applied to the job and its resources. | ||
| allocationPolicy.labels[labelName1] = labelValue1; | ||
| allocationPolicy.labels[labelName2] = labelValue2; | ||
|
|
||
| const job = new batch.Job({ | ||
| name: jobName, | ||
| taskGroups: [group], | ||
| labels: {env: 'testing', type: 'script'}, | ||
| allocationPolicy, | ||
| // We use Cloud Logging as it's an option available out of the box | ||
| logsPolicy: new batch.LogsPolicy({ | ||
| destination: batch.LogsPolicy.Destination.CLOUD_LOGGING, | ||
| }), | ||
| }); | ||
|
|
||
| // The job's parent is the project and region in which the job will run | ||
| const parent = `projects/${projectId}/locations/${region}`; | ||
|
|
||
| async function callCreateBatchLabelsAllocation() { | ||
| // Construct request | ||
| const request = { | ||
| parent, | ||
| jobId: jobName, | ||
| job, | ||
| }; | ||
|
|
||
| // Run request | ||
| const [response] = await batchClient.createJob(request); | ||
| console.log(JSON.stringify(response)); | ||
| } | ||
|
|
||
| callCreateBatchLabelsAllocation(); | ||
| // [END batch_labels_allocation] | ||
| } | ||
|
|
||
| process.on('unhandledRejection', err => { | ||
| console.error(err.message); | ||
| process.exitCode = 1; | ||
| }); | ||
|
|
||
| main(); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| // Copyright 2022 Google LLC | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // https://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| 'use strict'; | ||
|
|
||
| async function deleteJob(batchClient, projectId, region, jobId) { | ||
| const request = { | ||
| name: `projects/${projectId}/locations/${region}/jobs/${jobId}`, | ||
| }; | ||
| try { | ||
| await batchClient.deleteJob(request); | ||
| } catch (err) { | ||
| console.error('Deleting job failed: ', err); | ||
| } | ||
| } | ||
|
|
||
| module.exports = { | ||
| deleteJob, | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,60 @@ | ||
| /* | ||
| * Copyright 2020 Google LLC | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * https://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| 'use strict'; | ||
|
|
||
| const path = require('path'); | ||
| const assert = require('assert'); | ||
| const {describe, it} = require('mocha'); | ||
| const cp = require('child_process'); | ||
| const execSync = cmd => cp.execSync(cmd, {encoding: 'utf-8'}); | ||
| const cwd = path.join(__dirname, '..'); | ||
| const {BatchServiceClient} = require('@google-cloud/batch').v1; | ||
| const {deleteJob} = require('./batchClient_operations'); | ||
| const batchClient = new BatchServiceClient(); | ||
|
|
||
| describe('Create batch labels allocation', async () => { | ||
| const jobName = 'batch-labels-allocation-job'; | ||
| const region = 'europe-central2'; | ||
| let projectId; | ||
|
|
||
| before(async () => { | ||
| projectId = await batchClient.getProjectId(); | ||
| }); | ||
|
|
||
| after(async () => { | ||
| await deleteJob(batchClient, projectId, region, jobName); | ||
| }); | ||
|
|
||
| it('should create a new job with allocation policy labels', async () => { | ||
| const expectedAllocationLabels = { | ||
| 'batch-job-id': 'batch-labels-allocation-job', | ||
| vm_label_name_1: 'vmLabelValue1', | ||
| vm_label_name_2: 'vmLabelValue2', | ||
| }; | ||
|
|
||
| const response = JSON.parse( | ||
| execSync('node ./create/create_batch_labels_allocation.js', { | ||
| cwd, | ||
| }) | ||
| ); | ||
|
|
||
| assert.deepEqual( | ||
| response.allocationPolicy.labels, | ||
| expectedAllocationLabels | ||
| ); | ||
| }); | ||
| }); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like a new sample but copying an older header. please make sure samples that are new have 2024