Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: batch_labels_runnable #3792

Merged
merged 4 commits into from
Aug 19, 2024
Merged

feat: batch_labels_runnable #3792

merged 4 commits into from
Aug 19, 2024

Conversation

gryczj
Copy link
Contributor

@gryczj gryczj commented Aug 13, 2024

Description

Fixes #

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • Tests pass: npm test (see Testing)
  • Lint pass: npm run lint (see Style)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@gryczj gryczj added kokoro:run Add this label to force Kokoro to re-run the tests. samples Issues that are directly related to samples. api: batch Issues related to the Batch API. labels Aug 13, 2024
@gryczj gryczj self-assigned this Aug 13, 2024
@gryczj gryczj requested review from a team as code owners August 13, 2024 08:20
Copy link

snippet-bot bot commented Aug 13, 2024

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Aug 13, 2024
@gryczj gryczj added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels Aug 13, 2024
@gryczj gryczj force-pushed the batch-labels-runnable branch from 04c114c to 2af3748 Compare August 13, 2024 08:23
@kokoro-team kokoro-team removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Aug 13, 2024
@subfuzion subfuzion assigned subfuzion and unassigned gryczj Aug 13, 2024
Copy link
Contributor

@subfuzion subfuzion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, @gryczj

batch/create/create_batch_labels_runnable.js Outdated Show resolved Hide resolved
@gryczj gryczj added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels Aug 14, 2024
@gryczj gryczj force-pushed the batch-labels-runnable branch from 2af3748 to 78af3d1 Compare August 14, 2024 08:42
@kokoro-team kokoro-team removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Aug 14, 2024
@gryczj gryczj requested a review from subfuzion August 14, 2024 08:49
@gryczj gryczj force-pushed the batch-labels-runnable branch from 78af3d1 to 70ee024 Compare August 16, 2024 13:52
@gryczj gryczj added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels Aug 19, 2024
@gryczj gryczj force-pushed the batch-labels-runnable branch from 70ee024 to ac38c95 Compare August 19, 2024 16:50
@kokoro-team kokoro-team removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Aug 19, 2024
@gryczj gryczj requested a review from msampathkumar August 19, 2024 17:00
@subfuzion subfuzion merged commit 6fe7417 into main Aug 19, 2024
32 checks passed
@subfuzion subfuzion deleted the batch-labels-runnable branch August 19, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: batch Issues related to the Batch API. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants