Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: (data_catalog) update region tag in lookuptEntry.js #3953

Merged
merged 2 commits into from
Jan 16, 2025

Conversation

hivanalejandro
Copy link
Contributor

@hivanalejandro hivanalejandro commented Jan 16, 2025

Description

Migrate region "datacatalog_delete_fileset_quickstart_tag" to "data_catalog_delete_fileset_quickstart_tag"

Fixes b/390409205

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • Tests pass: npm test (see Testing)
  • Lint pass: npm run lint (see Style)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@hivanalejandro hivanalejandro requested review from a team as code owners January 16, 2025 17:10
Copy link
Contributor

@code-review-assist code-review-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi team,

I'm currently reviewing this pull request and will provide my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed:

This pull request by @hivanalejandro aims to fix bug b/390409205 by updating a region tag in the lookupEntry.js file within the datacatalog/cloud-client directory. Specifically, the changes involve migrating the region tag from datacatalog_delete_fileset_quickstart_tag to data_catalog_delete_fileset_quickstart_tag.

Here's a breakdown of the changes:

  • File: datacatalog/cloud-client/lookupEntry.js
    • Change 1: Added a new comment // [START data_catalog_lookup_dataset] before line 25.
    • Change 2: Added a new comment // [END data_catalog_lookup_dataset] after line 45.

The author has indicated that all tests and linting checks have passed. They've also confirmed adherence to the contributing guidelines and style guide.


A little haiku to lighten the mood:

Tags shift, a fix appears,
Code flows, bugs gently fade,
Clarity now reigns.

Thanks,
Gemini

Copy link

snippet-bot bot commented Jan 16, 2025

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added samples Issues that are directly related to samples. api: datacatalog Issues related to the Data Catalog API. labels Jan 16, 2025
Copy link
Contributor

@code-review-assist code-review-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The region tag was duplicated, resulting in two identical region tags. This has been corrected, and the unnecessary tag has been removed.

@@ -22,6 +22,7 @@
* documentation at https://cloud.google.com/data-catalog/docs.
*/
const main = async (projectId, datasetId) => {
// [START data_catalog_lookup_dataset]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Duplicated region tag. Removed one instance to correct the issue.

Suggested change
// [START data_catalog_lookup_dataset]
// [START data_catalog_lookup_dataset]

@@ -42,6 +43,7 @@
const response = await lookup();
console.log(response);
// [END datacatalog_lookup_dataset]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Duplicated region tag. Removed one instance to correct the issue.

Suggested change
// [END datacatalog_lookup_dataset]
// [END data_catalog_lookup_dataset]

@iennae iennae merged commit 5bb54cc into main Jan 16, 2025
14 checks passed
@iennae iennae deleted the hivanalejandro-migrate-region-step1-390409205 branch January 16, 2025 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: datacatalog Issues related to the Data Catalog API. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants