-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: (data_catalog) update region tag in lookuptEntry.js #3953
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi team,
I'm currently reviewing this pull request and will provide my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed:
This pull request by @hivanalejandro aims to fix bug b/390409205 by updating a region tag in the lookupEntry.js
file within the datacatalog/cloud-client
directory. Specifically, the changes involve migrating the region tag from datacatalog_delete_fileset_quickstart_tag
to data_catalog_delete_fileset_quickstart_tag
.
Here's a breakdown of the changes:
- File:
datacatalog/cloud-client/lookupEntry.js
- Change 1: Added a new comment
// [START data_catalog_lookup_dataset]
before line 25. - Change 2: Added a new comment
// [END data_catalog_lookup_dataset]
after line 45.
- Change 1: Added a new comment
The author has indicated that all tests and linting checks have passed. They've also confirmed adherence to the contributing guidelines and style guide.
A little haiku to lighten the mood:
Tags shift, a fix appears,
Code flows, bugs gently fade,
Clarity now reigns.
Thanks,
Gemini
Here is the summary of changes. You are about to add 1 region tag.
This comment is generated by snippet-bot.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The region tag was duplicated, resulting in two identical region tags. This has been corrected, and the unnecessary tag has been removed.
@@ -22,6 +22,7 @@ | |||
* documentation at https://cloud.google.com/data-catalog/docs. | |||
*/ | |||
const main = async (projectId, datasetId) => { | |||
// [START data_catalog_lookup_dataset] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -42,6 +43,7 @@ | |||
const response = await lookup(); | |||
console.log(response); | |||
// [END datacatalog_lookup_dataset] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description
Migrate region "datacatalog_delete_fileset_quickstart_tag" to "data_catalog_delete_fileset_quickstart_tag"
Fixes b/390409205
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.
Checklist
npm test
(see Testing)npm run lint
(see Style)GoogleCloudPlatform/nodejs-docs-samples
. Not a fork.