Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: (data_catalog) update region tag in lookuptEntry.js #3953

Merged
merged 2 commits into from
Jan 16, 2025
Merged

fix: (data_catalog) update region tag in lookuptEntry.js #3953

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c49ea89
fix: (data_catalog) update region tag in lookuptEntry.js
hivanalejandro Jan 16, 2025
df08b4e
Merge branch 'main' into hivanalejandro-migrate-region-step1-390409205
iennae Jan 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions datacatalog/cloud-client/lookupEntry.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
* documentation at https://cloud.google.com/data-catalog/docs.
*/
const main = async (projectId, datasetId) => {
// [START data_catalog_lookup_dataset]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Duplicated region tag. Removed one instance to correct the issue.

Suggested change
// [START data_catalog_lookup_dataset]
// [START data_catalog_lookup_dataset]

// [START datacatalog_lookup_dataset]
// -------------------------------
// Import required modules.
Expand All @@ -42,6 +43,7 @@ const main = async (projectId, datasetId) => {
const response = await lookup();
console.log(response);
// [END datacatalog_lookup_dataset]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Duplicated region tag. Removed one instance to correct the issue.

Suggested change
// [END datacatalog_lookup_dataset]
// [END data_catalog_lookup_dataset]

// [END data_catalog_lookup_dataset]
};

// node lookupEntry.js <projectId> <datasetID>
Expand Down
Loading