fix: (data_catalog) delete deprecated region tag in createtEntryGroup.js

[hivanalejandro]

Description

Remove region tag "datacatalog_create_entry_group_tag"

Fixes b/389693076

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

• I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
• Tests pass: npm test (see Testing)
• Lint pass: npm run lint (see Style)
• These samples need a new API enabled in testing projects to pass (let us know which ones)
• These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
• This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
• This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
• This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
• This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
• Please merge this PR for me once it is approved

[code-review-assist]

Hi team,

I'm currently reviewing this pull request and will provide my feedback shortly. In the meantime, here's a summary for you and other reviewers to quickly get up to speed:

This pull request, submitted by @hivanalejandro, aims to fix a bug by removing a deprecated region tag from the createEntryGroup.js file within the datacatalog/cloud-client directory. The specific tag removed is datacatalog_create_entry_group_tag.

Here's a breakdown of the changes:

• File Modified: datacatalog/cloud-client/createEntryGroup.js
• Changes: The pull request removes two lines of code (lines 29 and 62 in the original file) that included the deprecated tag. The before and after diffs show the removal clearly. Specifically:
  • Line 29: // [START datacatalog_create_entry_group_tag] was removed.
  • Line 62: // [END datacatalog_create_entry_group_tag] was removed.
• Intent: To update the code to reflect current best practices and remove the now-obsolete region tag, addressing bug b/389693076.

The author has indicated that all tests and linting checks have passed. They've also checked off all items in their checklist.

---

A little haiku to lighten the mood:

Tag removed, code clean,
Bugs banished, peace restored now,
Git's happy dance plays.

Thanks!
Gemini

[snippet-bot]

Here is the summary of changes.

You are about to delete 1 region tag.

• datacatalog/cloud-client/createEntryGroup.js:29, tag datacatalog_create_entry_group_tag

---

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

• Refresh this comment

[code-review-assist]

This pull request removes the deprecated region tag "datacatalog_create_entry_group_tag" from the createEntryGroup.js file. This change correctly addresses the issue described in the linked bug report. The removal of the deprecated tag improves the clarity and maintainability of the code. The checklist items related to testing and linting are important for ensuring code quality. I've referenced the Node.js Samples Style Guide in this review.

[code-review-assist]

Per the Node.js Samples Style Guide, there should be only one empty line between the require statements and the code.

Suggestion: Remove the extra empty line.

Suggested change

	// -------------------------------
	// -------------------------------
	// Import required modules.
	// -------------------------------
	const {DataCatalogClient} = require('@google-cloud/datacatalog').v1;
	const datacatalog = new DataCatalogClient();