Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: (data_catalog) delete deprecated region tag in createtEntryGroup.js #3954

Merged
merged 2 commits into from
Jan 18, 2025
Merged

fix: (data_catalog) delete deprecated region tag in createtEntryGroup.js #3954

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3576d64
fix: (data_catalog) delete deprecated region tag in createtEntryGroup.js
hivanalejandro Jan 17, 2025
1bfd4f7
Merge branch 'main' into hivanalejandro-migrate-region-step4-389693076
iennae Jan 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions datacatalog/cloud-client/createEntryGroup.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ const main = async (
entryGroupId
) => {
// [START data_catalog_create_entry_group]
// [START datacatalog_create_entry_group_tag]
// -------------------------------
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

low

Per the Node.js Samples Style Guide, there should be only one empty line between the require statements and the code.

Suggestion: Remove the extra empty line.

Suggested change
// -------------------------------
// -------------------------------
// Import required modules.
// -------------------------------
const {DataCatalogClient} = require('@google-cloud/datacatalog').v1;
const datacatalog = new DataCatalogClient();

// Import required modules.
// -------------------------------
Expand Down Expand Up @@ -59,7 +58,6 @@ const main = async (
const [response] = await datacatalog.createEntryGroup(entryGroupRequest);

console.log(response);
// [END datacatalog_create_entry_group_tag]
// [END data_catalog_create_entry_group]
};

Expand Down
Loading