-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: (data_catalog) delete deprecated region tag in deleteFilesettEntry #3955
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi team,
I'm Gemini, and I'm currently reviewing this pull request. In the meantime, here's a summary for you and other reviewers to quickly get up to speed:
This pull request, submitted by @hivanalejandro, aims to fix a deprecated region tag in the deleteFilesetEntry.js
sample within the nodejs-docs-samples
repository. Specifically, it removes the deprecated datacatalog_delete_fileset_quickstart_tag
region tag.
Here's a breakdown of the changes:
- File Changed:
datacatalog/quickstart/deleteFilesetEntry.js
- Changes: The pull request removes two lines of code, lines 30 and 75 in
deleteFilesetEntry.js
, which represent the deprecated region tag. This ensures the sample code remains up-to-date and avoids potential issues.- Line 30: Removed
// [START datacatalog_delete_fileset_quickstart_tag]
- Line 75: Removed
// [END datacatalog_delete_fileset_quickstart_tag]
- Line 30: Removed
The pull request addresses issue b/389895440 and includes a completed checklist confirming adherence to the project's style guidelines and testing procedures.
My full review will follow shortly.
A little haiku to brighten your day:
Code flows like a stream,
Tags removed, the path is clear,
Clean code, joy abounds.
Here is the summary of changes. You are about to delete 1 region tag.
This comment is generated by snippet-bot.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pull request removes the deprecated region tag datacatalog_delete_fileset_quickstart_tag
from the deleteFilesetEntry.js
file. The change correctly removes the tag from both the start and end of the relevant code block. The commit message clearly describes the change and references the related issue. The checklist is mostly complete, but there are a few items that could be checked or updated.
@@ -27,7 +27,6 @@ const main = async ( | |||
entryId | |||
) => { | |||
// [START data_catalog_delete_fileset_quickstart] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider adding a brief comment explaining the purpose of this region tag and the code block it encloses. This will improve the readability and maintainability of the code. For example, you could add a comment like // Sample code to delete a fileset entry
.
// [START data_catalog_delete_fileset_quickstart] | |
// [START data_catalog_delete_fileset_quickstart] | |
// Sample code to delete a fileset entry |
Description
Remove region "datacatalog_delete_fileset_quickstart_tag"
Fixes b/389895440
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.
Checklist
npm test
(see Testing)npm run lint
(see Style)GoogleCloudPlatform/nodejs-docs-samples
. Not a fork.