Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: (data_catalog) delete deprecated region tag in deleteFilesettEntry #3955

Merged
merged 1 commit into from
Jan 18, 2025

Conversation

hivanalejandro
Copy link
Contributor

@hivanalejandro hivanalejandro commented Jan 17, 2025

Description

Remove region "datacatalog_delete_fileset_quickstart_tag"

Fixes b/389895440

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • Tests pass: npm test (see Testing)
  • Lint pass: npm run lint (see Style)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@hivanalejandro hivanalejandro requested review from a team as code owners January 17, 2025 21:25
Copy link
Contributor

@code-review-assist code-review-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi team,

I'm Gemini, and I'm currently reviewing this pull request. In the meantime, here's a summary for you and other reviewers to quickly get up to speed:

This pull request, submitted by @hivanalejandro, aims to fix a deprecated region tag in the deleteFilesetEntry.js sample within the nodejs-docs-samples repository. Specifically, it removes the deprecated datacatalog_delete_fileset_quickstart_tag region tag.

Here's a breakdown of the changes:

  • File Changed: datacatalog/quickstart/deleteFilesetEntry.js
  • Changes: The pull request removes two lines of code, lines 30 and 75 in deleteFilesetEntry.js, which represent the deprecated region tag. This ensures the sample code remains up-to-date and avoids potential issues.
    • Line 30: Removed // [START datacatalog_delete_fileset_quickstart_tag]
    • Line 75: Removed // [END datacatalog_delete_fileset_quickstart_tag]

The pull request addresses issue b/389895440 and includes a completed checklist confirming adherence to the project's style guidelines and testing procedures.

My full review will follow shortly.


A little haiku to brighten your day:

Code flows like a stream,
Tags removed, the path is clear,
Clean code, joy abounds.

@product-auto-label product-auto-label bot added samples Issues that are directly related to samples. api: datacatalog Issues related to the Data Catalog API. labels Jan 17, 2025
Copy link

snippet-bot bot commented Jan 17, 2025

Here is the summary of changes.

You are about to delete 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

Copy link
Contributor

@code-review-assist code-review-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request removes the deprecated region tag datacatalog_delete_fileset_quickstart_tag from the deleteFilesetEntry.js file. The change correctly removes the tag from both the start and end of the relevant code block. The commit message clearly describes the change and references the related issue. The checklist is mostly complete, but there are a few items that could be checked or updated.

@@ -27,7 +27,6 @@ const main = async (
entryId
) => {
// [START data_catalog_delete_fileset_quickstart]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

low

Consider adding a brief comment explaining the purpose of this region tag and the code block it encloses. This will improve the readability and maintainability of the code. For example, you could add a comment like // Sample code to delete a fileset entry.

Suggested change
// [START data_catalog_delete_fileset_quickstart]
// [START data_catalog_delete_fileset_quickstart]
// Sample code to delete a fileset entry

@iennae iennae merged commit 8c189db into main Jan 18, 2025
19 checks passed
@iennae iennae deleted the hivanalejandro-migrate-region-step4-389895440 branch January 18, 2025 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: datacatalog Issues related to the Data Catalog API. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants