Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: (data_catalog) delete deprecated region tag in deleteFilesettEntry #3955

Merged
merged 1 commit into from
Jan 18, 2025
Merged

fix: (data_catalog) delete deprecated region tag in deleteFilesettEntry #3955

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions datacatalog/quickstart/deleteFilesetEntry.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ const main = async (
entryId
) => {
// [START data_catalog_delete_fileset_quickstart]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

low

Consider adding a brief comment explaining the purpose of this region tag and the code block it encloses. This will improve the readability and maintainability of the code. For example, you could add a comment like // Sample code to delete a fileset entry.

Suggested change
// [START data_catalog_delete_fileset_quickstart]
// [START data_catalog_delete_fileset_quickstart]
// Sample code to delete a fileset entry

// [START datacatalog_delete_fileset_quickstart_tag]
// -------------------------------
// Import required modules.
// -------------------------------
Expand Down Expand Up @@ -72,7 +71,6 @@ const main = async (
console.log('Entry Group does not exist or is not empty.');
}
};
// [END datacatalog_delete_fileset_quickstart_tag]
// [END data_catalog_delete_fileset_quickstart]

// node deleteFilesetEntry.js <projectId> <entryGroupId> <entryId>
Expand Down
Loading