-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: (appengine) update region tag in appengine/building-an-app/build/server.js & appengine/building-an-app/update/server.js #3959
Conversation
Here is the summary of changes. You are about to add 2 region tags.
You are about to delete 2 region tags.
This comment is generated by snippet-bot.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi team,
I'm currently reviewing this pull request and will provide my feedback shortly. In the meantime, here's a summary for you and other reviewers to quickly get up to speed:
This pull request by @hivanalejandro addresses issues b/391863712 and b/391865122 by updating region tags in the server.js
files within the appengine/building-an-app/build
and appengine/building-an-app/update
directories. The changes involve adding and removing // [START]
and // [END]
comments related to Google App Engine region tags. Specifically:
appengine/building-an-app/build/server.js
: The comment// [START gae_build_web_server_app]
was added on lines 17 and 34.appengine/building-an-app/update/server.js
: The comment// [START gae_update_web_server_app]
was added on lines 17 and 63.- Additionally, several
// [START datacatalog_create_fileset_tag]
and// [END datacatalog_create_fileset_tag]
comments were removed fromdatacatalog/cloud-client/createFilesetEntry.js
anddatacatalog/quickstart/createFilesetEntry.js
.
The intent is to improve the accuracy and clarity of the App Engine documentation samples. The changes appear straightforward and well-documented.
Here's a little haiku to lighten the mood:
Tags in the code flow,
Clarity's gentle breezes blow,
Docs now shine so bright.
Thanks,
Gemini
Gemini encountered an error creating the review. You can try again by commenting |
Description
Fixes
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.
Checklist
npm test
(see Testing)npm run lint
(see Style)GoogleCloudPlatform/nodejs-docs-samples
. Not a fork.