Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: (appengine) update region tag in appengine/building-an-app/build/server.js & appengine/building-an-app/update/server.js #3959

Merged
merged 9 commits into from
Jan 23, 2025

Conversation

hivanalejandro
Copy link
Contributor

@hivanalejandro hivanalejandro commented Jan 23, 2025

Description

Fixes

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • Tests pass: npm test (see Testing)
  • Lint pass: npm run lint (see Style)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@hivanalejandro hivanalejandro requested review from a team as code owners January 23, 2025 17:53
Copy link

snippet-bot bot commented Jan 23, 2025

Here is the summary of changes.

You are about to add 2 region tags.
You are about to delete 2 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Jan 23, 2025
Copy link
Contributor

@code-review-assist code-review-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi team,

I'm currently reviewing this pull request and will provide my feedback shortly. In the meantime, here's a summary for you and other reviewers to quickly get up to speed:

This pull request by @hivanalejandro addresses issues b/391863712 and b/391865122 by updating region tags in the server.js files within the appengine/building-an-app/build and appengine/building-an-app/update directories. The changes involve adding and removing // [START] and // [END] comments related to Google App Engine region tags. Specifically:

  • appengine/building-an-app/build/server.js: The comment // [START gae_build_web_server_app] was added on lines 17 and 34.
  • appengine/building-an-app/update/server.js: The comment // [START gae_update_web_server_app] was added on lines 17 and 63.
  • Additionally, several // [START datacatalog_create_fileset_tag] and // [END datacatalog_create_fileset_tag] comments were removed from datacatalog/cloud-client/createFilesetEntry.js and datacatalog/quickstart/createFilesetEntry.js.

The intent is to improve the accuracy and clarity of the App Engine documentation samples. The changes appear straightforward and well-documented.


Here's a little haiku to lighten the mood:

Tags in the code flow,
Clarity's gentle breezes blow,
Docs now shine so bright.

Thanks,
Gemini

@product-auto-label product-auto-label bot added api: appengine Issues related to the App Engine Admin API API. api: datacatalog Issues related to the Data Catalog API. asset: pattern DEE Asset tagging - Pattern. labels Jan 23, 2025
Copy link
Contributor

Gemini encountered an error creating the review. You can try again by commenting @code-review-assist review.

@hivanalejandro hivanalejandro marked this pull request as draft January 23, 2025 18:56
@hivanalejandro hivanalejandro marked this pull request as ready for review January 23, 2025 23:13
@iennae iennae merged commit 30cb1d7 into main Jan 23, 2025
24 checks passed
@iennae iennae deleted the hivanalejandro-migrate-region-step1-391863712 branch January 23, 2025 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: appengine Issues related to the App Engine Admin API API. api: datacatalog Issues related to the Data Catalog API. asset: pattern DEE Asset tagging - Pattern. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants