Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: (appengine) update region tag in appengine/building-an-app/build/server.js & appengine/building-an-app/update/server.js #3959

Merged
merged 9 commits into from
Jan 23, 2025
Merged

fix: (appengine) update region tag in appengine/building-an-app/build/server.js & appengine/building-an-app/update/server.js #3959

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
65c3c8e
fix: (data_catalog) delete deprecated region tag in createFilesettEnt…
hivanalejandro Jan 22, 2025
8e2456d
fix: (data_catalog) delete deprecated region tag in quickstart/create…
hivanalejandro Jan 22, 2025
1e17f40
fix: (appengine) update region tag in appengine/building-an-app/build…
hivanalejandro Jan 23, 2025
5d63de6
fix: (appengine) update region tag in appengine/building-an-app/updat…
hivanalejandro Jan 23, 2025
283e5b5
fix linting issues
hivanalejandro Jan 23, 2025
80c5b6a
added the gae_build_web_server_app test
hivanalejandro Jan 23, 2025
5fb3b5f
added the gae_update_web_server_app test
hivanalejandro Jan 23, 2025
29d5627
fix linting issues
hivanalejandro Jan 23, 2025
b7293b7
fix region tags
hivanalejandro Jan 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions appengine/building-an-app/build/server.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@

'use strict';

// [START gae_build_web_server_app]
// [START app]
// [START gae_app]
const express = require('express');
Expand All @@ -30,5 +31,6 @@ app.listen(PORT, () => {
});
// [END gae_app]
// [END app]
// [END gae_build_web_server_app]

module.exports = app;
6 changes: 6 additions & 0 deletions appengine/building-an-app/build/test/server.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,3 +21,9 @@ describe('gae_app', () => {
await supertest(app).get('/').expect(200);
});
})

describe('gae_build_web_server_app', () => {
it('should be listening', async () => {
await supertest(app).get('/').expect(200);
});
})
2 changes: 2 additions & 0 deletions appengine/building-an-app/update/server.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@

'use strict';

// [START gae_update_web_server_app]
// [START app]
// [START gae_update_app]
const express = require('express');
Expand Down Expand Up @@ -59,5 +60,6 @@ app.listen(PORT, () => {
});
// [END gae_update_app]
// [END app]
// [END gae_update_web_server_app]

module.exports = app;
11 changes: 11 additions & 0 deletions appengine/building-an-app/update/test/server.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,17 @@ describe('gae_update_app', () => {
});
});

describe('gae_update_web_server_app', () => {
it('should send greetings', async () => {
await requestObj
.get('/')
.expect(200)
.expect(response => {
assert.strictEqual(response.text, 'Hello from App Engine!');
});
});
});

describe('gae_add_display_form add_display_form', () => {
it('should display form', async () => {
await requestObj
Expand Down
2 changes: 0 additions & 2 deletions datacatalog/cloud-client/createFilesetEntry.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ const main = async (
entryId
) => {
// [START data_catalog_create_fileset]
// [START datacatalog_create_fileset_tag]
// -------------------------------
// Import required modules.
// -------------------------------
Expand Down Expand Up @@ -101,7 +100,6 @@ const main = async (
const [response] = await datacatalog.createEntry(request);

console.log(response);
// [END datacatalog_create_fileset_tag]
// [END data_catalog_create_fileset]
};

Expand Down
2 changes: 0 additions & 2 deletions datacatalog/quickstart/createFilesetEntry.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ const main = async (
entryId
) => {
// [START data_catalog_create_fileset_quickstart]
// [START datacatalog_create_fileset_quickstart_tag]
// -------------------------------
// Import required modules.
// -------------------------------
Expand Down Expand Up @@ -125,7 +124,6 @@ const main = async (

console.log(response);
};
// [END datacatalog_create_fileset_quickstart_tag]
// [END data_catalog_create_fileset_quickstart]

// node createFilesetEntry.js <projectId> <entryGroupId> <entryId>
Expand Down
Loading