[Issue 2665] Update analytics db settings to recognize empty pwd setting in env #2796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavidDudas-Intuitial
requested review from
coilysiren,
widal001 and
acouch
as code owners
6 tasks
coilysiren
approved these changes
Nov 8, 2024
That's exactly right. When running in AWS, the ENV should presumably have a pwd value of |
DavidDudas-Intuitial
added a commit
that referenced
this pull request
Nov 9, 2024
…wd (#2799) ## Summary Fixes #2665 ### Time to review: __2 mins__ ## Changes proposed > What was added, updated, or removed in this PR. Adds a switch in `analytics/integrations/db.py` that determines which value to use for a DB password when connecting to Postgres: either the value in `local.env` or an IAM token, depending on an environment variable. Also adds better exception handling, to make errors easier to spot in CI. ## Context for reviewers > Testing instructions, background context, more in-depth details of the implementation, and anything else you'd like to call out or ask reviewers. Explain how the changes were verified. This is a follow up to previous PRs, #2786 and #2796, and part of an effort to get `analytics` step functions to successfully connect to Postgres DB in a CI environment. ## Additional information > Screenshots, GIF demos, code examples or output to help show the changes working as expected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2665
Time to review: 1 min
Changes proposed
Made
DBSettings.passwordan optional field inanalytics/config.py, thereby allowing the value to beNone, which in turn allows IAM token-creation to occur.Context for reviewers
Additional information