Skip to content

Added Text in the Json File #10027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Added Text in the Json File #10027

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0cf147f
Merge pull request #385 from IDEMSInternational/master
MeSophie Oct 30, 2025
bc84681
Added xtext in the Json File
MeSophie Oct 30, 2025
b070222
Small change made
MeSophie Oct 30, 2025
2f7bbed
Merge pull request #386 from IDEMSInternational/master
MeSophie Nov 1, 2025
63ee4cc
Added Text in Json File
MeSophie Nov 2, 2025
a1ff9ab
Design changes made on some dialogues
MeSophie Nov 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 21 additions & 21 deletions instat/dlgBoxPlot.designer.vb
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 6 additions & 1 deletion instat/translations/en/r_instat_not_menus.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,7 @@
"Add a new tab.": "Add a new tab.",
"add a value (default 10) to each number in the list": "add a value (default 10) to each number in the list",
"Add All": "Add All",
"Add Boxplot": "Add Boxplot",
"Add Calculation": "Add Calculation",
"Add Colour Scale": "Add Colour Scale",
"Add Comment": "Add Comment",
Expand Down Expand Up @@ -2773,6 +2774,7 @@
"Label9": "Label9",
"Label:": "Label:",
"label:": "label:",
"Label Outliers": "Label Outliers",
"labelled": "labelled",
"labelled ": "labelled ",
"Labelled Convert": "Labelled Convert",
Expand Down Expand Up @@ -3789,7 +3791,7 @@
"Out of Days:": "Out of Days:",
"Outer": "Outer",
"Outlier": "Outlier",
"Outlier Coefficiennt :": "Outlier Coefficiennt :",
"Outlier Coefficient :": "Outlier Coefficient :",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

While you've corrected the typo for Outlier Coefficient : in this translation file, the source code that displays this text in the UI has not been updated. The Text property for lblOutlierCoefficient in instat/dlgBoxPlot.designer.vb on line 550 is still set to the old value with the typo: "Outlier Coefficiennt :".

For the translation to work, the text in the source code must exactly match the key in this JSON file. Please update the Text property in the designer file to match the corrected key.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MeSophie this looks like a useful spot by the robots

"outlier.colour": "outlier.colour",
"outlier.shape": "outlier.shape",
"outlier.size": "outlier.size",
Expand Down Expand Up @@ -5315,6 +5317,9 @@
"Summarise Red Flags by Country (or other)...": "Summarise Red Flags by Country (or other)...",
"Summarise Red Flags by Country and Year (or other)...": "Summarise Red Flags by Country and Year (or other)...",
"Summarise...": "Summarise...",
"Summary_count": "Summary_count",
"Summary_count_all": "Summary_count_all",
"Summary_sum": "Summary_sum",
Comment on lines +5338 to +5340
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The new keys Summary_count, Summary_count_all, and Summary_sum appear to be internal identifiers rather than user-facing text. For translation files, it's a best practice to use the full, descriptive English text as the key. This provides essential context for translators, making their job easier and reducing the chance of incorrect translations. Using identifiers as keys can be confusing without additional context.

If these are indeed for UI text, consider changing them to be more descriptive. For example, "Summary (count)" is more explicit than "Summary_count".

Suggested change
"Summary_count": "Summary_count",
"Summary_count_all": "Summary_count_all",
"Summary_sum": "Summary_sum",
"Summary (count)": "Summary (count)",
"Summary (count all)": "Summary (count all)",
"Summary (sum)": "Summary (sum)",

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we want to do this one

"Summary": "Summary",
"summary": "summary",
"Summary : ": "Summary : ",
Expand Down
Loading