Skip to content

TextElement: Add support for placeholder attribute#148

Merged
nilmerg merged 1 commit into
mainfrom
text-input-support-placeholder-attr
Aug 5, 2025
Merged

TextElement: Add support for placeholder attribute#148
nilmerg merged 1 commit into
mainfrom
text-input-support-placeholder-attr

Conversation

@sukhwinder33445

Copy link
Copy Markdown
Contributor

No description provided.

@nilmerg nilmerg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also add a test case

Comment thread src/FormElement/TextElement.php Outdated
@sukhwinder33445 sukhwinder33445 force-pushed the text-input-support-placeholder-attr branch from 3b42124 to 37ade69 Compare August 1, 2025 10:50
@sukhwinder33445 sukhwinder33445 requested a review from nilmerg August 1, 2025 10:51
@sukhwinder33445 sukhwinder33445 force-pushed the text-input-support-placeholder-attr branch from 37ade69 to b06f33f Compare August 1, 2025 10:54
Comment thread tests/FormElement/TextElementTest.php Outdated
Comment thread tests/FormElement/TextElementTest.php
@nilmerg nilmerg added this to the v0.9.0 milestone Aug 4, 2025
@nilmerg nilmerg added the enhancement New feature or request label Aug 4, 2025
@sukhwinder33445 sukhwinder33445 force-pushed the text-input-support-placeholder-attr branch from b06f33f to 20f2637 Compare August 4, 2025 11:05
@sukhwinder33445 sukhwinder33445 requested a review from nilmerg August 4, 2025 11:05
Comment thread tests/FormElement/TextElementTest.php Outdated
Comment thread tests/FormElement/TextElementTest.php Outdated
@sukhwinder33445 sukhwinder33445 force-pushed the text-input-support-placeholder-attr branch from 20f2637 to 082990a Compare August 4, 2025 15:07
@sukhwinder33445 sukhwinder33445 requested a review from nilmerg August 4, 2025 15:08
@nilmerg nilmerg merged commit 1509f38 into main Aug 5, 2025
10 checks passed
@nilmerg nilmerg deleted the text-input-support-placeholder-attr branch August 5, 2025 08:27
nilmerg pushed a commit to Icinga/ipl-web that referenced this pull request Aug 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla/signed enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants