-
Notifications
You must be signed in to change notification settings - Fork 438
Use importlib in place of backports.test.support #375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
pulling in `unittest2` as a runtime dependency instead of a test dependency. It's also really not needed, as the functionality that it provides was not being called. Just use importlib instead. Remove unused functions in s_utils.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix import_module call.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix accidental import removal.
Thanks for that, was just writing you a message. Now unnecessary :-)
|
No problem. Would love to see this merged and a new pypi release out. Right now it's polluting our dependency tree. Thanks! |
v4.4.0 on pypi now
|
Will do it later today.
|
Remove (undeclared dependency) usage of backports.test.support. This was
pulling in
unittest2
as a runtime dependency instead of a testdependency. It's also really not needed, as the functionality that it
provides was not being called. Just use importlib instead.
Remove unused functions in s_utils.py & alphabetize imports. Order according to: Python core, 3rd party, local pacakge.