Skip to content

Use importlib in place of backports.test.support #375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 26, 2016
Merged

Use importlib in place of backports.test.support #375

merged 3 commits into from
Oct 26, 2016

Conversation

dsully
Copy link

@dsully dsully commented Oct 26, 2016

Remove (undeclared dependency) usage of backports.test.support. This was
pulling in unittest2 as a runtime dependency instead of a test
dependency. It's also really not needed, as the functionality that it
provides was not being called. Just use importlib instead.

Remove unused functions in s_utils.py & alphabetize imports. Order according to: Python core, 3rd party, local pacakge.

Dan Sully and others added 2 commits October 26, 2016 10:20
pulling in `unittest2` as a runtime dependency instead of a test
dependency. It's also really not needed, as the functionality that it
provides was not being called. Just use importlib instead.

Remove unused functions in s_utils.py
Copy link
Author

@dsully dsully left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix import_module call.

Copy link
Author

@dsully dsully left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix accidental import removal.

@rohe
Copy link
Contributor

rohe commented Oct 26, 2016

Thanks for that, was just writing you a message. Now unnecessary :-)

On 26 Oct 2016, at 07:49, Dan Sully [email protected] wrote:

@dsully commented on this pull request.

Fix import_module call.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub #375 (review), or mute the thread https://github.com/notifications/unsubscribe-auth/AAGGPL1YTQ8KbNfkQu3NMbym9TBFoNu3ks5q32iGgaJpZM4KhO24.

@dsully
Copy link
Author

dsully commented Oct 26, 2016

No problem. Would love to see this merged and a new pypi release out. Right now it's polluting our dependency tree.

Thanks!

@rohe rohe merged commit b8c1ae7 into IdentityPython:master Oct 26, 2016
@rohe
Copy link
Contributor

rohe commented Oct 27, 2016

v4.4.0 on pypi now

On 26 Oct 2016, at 11:03, Dan Sully [email protected] wrote:

No problem. Would love to see this merged and a new pypi release out. Right now it's polluting our dependency tree.

Thanks!


You are receiving this because you commented.
Reply to this email directly, view it on GitHub #375 (comment), or mute the thread https://github.com/notifications/unsubscribe-auth/AAGGPMS-VGgaLtBNfFLQqH7Dzq_Wnjc6ks5q35YFgaJpZM4KhO24.

@rohe
Copy link
Contributor

rohe commented Oct 27, 2016

Will do it later today.
Thanks!

On 26 Oct 2016, at 11:03, Dan Sully [email protected] wrote:

No problem. Would love to see this merged and a new pypi release out. Right now it's polluting our dependency tree.

Thanks!


You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants