Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Themes: Add support for adjusting spacing via CSS vars #11368

Closed
40 tasks done
simeonoff opened this issue Apr 11, 2022 · 1 comment · Fixed by #11452
Closed
40 tasks done

Themes: Add support for adjusting spacing via CSS vars #11368

simeonoff opened this issue Apr 11, 2022 · 1 comment · Fixed by #11452
Assignees
@simeonoff
Labels
display-density ✨ themes status: inactive Used to stale issues and pull requests 🧰 feature-request version: 14.1.x ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.

Comments

@simeonoff
Copy link
Collaborator

simeonoff commented Apr 11, 2022 •
edited
Loading

Is your feature request related to a problem? Please describe.

The margin/padding and other spacing properties in all component themes are hardcoded and not easy to customize without overriding the class rules bundled with the themes.

Describe the solution you'd like

We can provide several spacing CSS variables that enable the global padding/margin configuration for all components.
@simeonoff simeonoff self-assigned this Apr 11, 2022
@simeonoff simeonoff mentioned this issue Apr 18, 2022
Closed
14 tasks
@SisIvanova SisIvanova mentioned this issue Apr 19, 2022
Merged
14 tasks
desig9stein added a commit that referenced this issue Apr 20, 2022
@desig9stein
feat(action-strip): use new spacing() function for margin and paddings.
e934b46 
Closes #11368
@desig9stein desig9stein mentioned this issue Apr 20, 2022
Merged
14 tasks
@SisIvanova SisIvanova linked a pull request May 9, 2022 that will close this issue
refactor(chip): use spacing for margin and padding #11452
Merged
14 tasks
@simeonoff simeonoff added ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged. version: 14.1.x and removed 🆕 status: new version: 13.2.x labels Jun 20, 2022
@github-actions
Copy link

There has been no recent activity and this issue has been marked inactive.

@github-actions github-actions bot added the status: inactive Used to stale issues and pull requests label Aug 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simeonoff simeonoff

Labels
display-density ✨ themes status: inactive Used to stale issues and pull requests 🧰 feature-request version: 14.1.x ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.
Projects
None yet
Milestone
No milestone
1 participant
@simeonoff