refactor: Column moving behavior #10506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teodosiah
added
the
🛠️ status: in-development
mmart1n
force-pushed
the
rkaraivanov/column-moving-grid-prop
branch
from
b2233a1 to
730797e
Compare
…com/IgniteUI/igniteui-angular into rkaraivanov/column-moving-grid-prop
…com/IgniteUI/igniteui-angular into rkaraivanov/column-moving-grid-prop
…into rkaraivanov/column-moving-grid-prop
teodosiah
added
❌ status: awaiting-test
kdinev
previously approved these changes
Dec 16, 2021
ddaribo
added
💥 status: in-test
kdinev
reviewed
Jan 4, 2022
| @@ -424,6 +424,9 @@ export class IgxColumnComponent implements AfterContentInit, OnDestroy, ColumnTy | |||
| /** | |||
| * Sets/gets whether the column is movable. | |||
| * Default value is `false`. | |||
| * | |||
| * @deprecated in version 13.1.0. Use `IgxGridComponent.moving` instead. | |||
There was a problem hiding this comment.
Shouldn't this be at the beginning of the comment?
kdinev
previously approved these changes
Jan 4, 2022
kdinev
approved these changes
Jan 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10176
Additional information (check all that apply):
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)