Skip to content

feat(icons): add the ability to replace icons via service #14035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 52 commits into from
Jun 27, 2024
Merged

feat(icons): add the ability to replace icons via service #14035

merged 52 commits into from
Jun 27, 2024

Conversation

simeonoff
Copy link
Collaborator

@simeonoff simeonoff commented Apr 1, 2024 •
edited
Loading

Closes #13987

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

simeonoff added 30 commits April 1, 2024 10:03
@simeonoff
feat(icons): add the ability to replace icons via service
e34b7ed 
initial commit
@simeonoff
refactor(icon): update service and icon to support dynamic changes
e201ae5
@simeonoff
Merge branch 'master' into simeonoff/configurable-icons
5c82c67
@simeonoff
spec(expansion-panel): fix failing tests
4191a03
@simeonoff
fix(icon): ligatures not rendered correctly
9b7fbcc
@simeonoff
refactor(icon): update template to remove empty spaces
b6eebf2
@simeonoff
refactor(icon): update service and component
9e2639a
@simeonoff
Merge branch 'master' into simeonoff/configurable-icons
2aa4b23
@simeonoff
Merge branch 'master' into simeonoff/configurable-icons
efc236a
@simeonoff
feat(icon-service): support font family name prefixes
f639792
@simeonoff
refactor(icon): don't set icon family when instantiating icons
22ec4bd
@simeonoff
spec(icon-service): add more tests
8446e2f
@simeonoff
spec(icon): add component tests
052094d
@simeonoff
Merge branch 'master' into simeonoff/configurable-icons
3b57cdf
@simeonoff
Merge branch 'master' into simeonoff/configurable-icons
fad5f11
@simeonoff
Merge branch 'master' into simeonoff/configurable-icons
9c3254a
@simeonoff
Merge branch 'master' into simeonoff/configurable-icons
078891a
@simeonoff
Merge branch 'master' into simeonoff/configurable-icons
6d2f958
@simeonoff
Merge branch 'master' into simeonoff/configurable-icons
82d04ad
@simeonoff
Merge branch 'master' into simeonoff/configurable-icons
825da48
@simeonoff
refactor(*): add icon references for several components
36bed26
@simeonoff
refactor(carousel): use service to derive theme icon
3a0aafa
@simeonoff
Merge branch 'master' into simeonoff/configurable-icons
9d3da53
@simeonoff
refactor(theme-service): make init method private
1536b4b
@simeonoff
refactor(chip): use icon references
e346c3a
@simeonoff
refactor(input-group): use theme service to get theme
2137175
@simeonoff
refactor(combo, simple-combo): use icon references
5f26f5e
@simeonoff
spec(*): fix failing tests
a9bb6f3
@simeonoff
Merge branch 'master' into simeonoff/configurable-icons
b468c1c
@simeonoff
Merge branch 'master' into simeonoff/configurable-icons
5ed1bdb
@simeonoff simeonoff added icon-service ❌ status: awaiting-test PRs awaiting manual verification labels May 23, 2024
@simeonoff simeonoff requested a review from damyanpetev May 23, 2024 15:15
@simeonoff simeonoff marked this pull request as ready for review May 28, 2024 11:49
@simeonoff simeonoff requested a review from rkaraivanov June 10, 2024 08:10
@ddaribo ddaribo mentioned this pull request Jun 19, 2024
Merged
14 tasks
@rkaraivanov rkaraivanov added 💥 status: in-test PRs currently being tested and removed ❌ status: awaiting-test PRs awaiting manual verification labels Jun 25, 2024
@rkaraivanov rkaraivanov added ✅ status: verified Applies to PRs that have passed manual verification and removed 💥 status: in-test PRs currently being tested labels Jun 27, 2024
@rkaraivanov rkaraivanov merged commit a1a2407 into master Jun 27, 2024
6 checks passed
@rkaraivanov rkaraivanov deleted the simeonoff/configurable-icons branch June 27, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkaraivanov rkaraivanov rkaraivanov approved these changes

@damyanpetev damyanpetev Awaiting requested review from damyanpetev

Assignees

@damyanpetev damyanpetev

Labels
🖼️ icon icon-service version: 18.1.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Provide a way to replace part of (or all) icons used by components with icons from other icon sets
4 participants
@simeonoff @rkaraivanov @damyanpetev @ChronosSF