Revert "Row pinning + export to excel" #7069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MayaKirova
changed the base branch from
master
to
SKrastev/grid-disabled-pin-row
added 2 commits
April 10, 2020 19:25
…ps://github.com/IgniteUI/igniteui-angular into revert-6972-mkirova/row-pinning-export-to-excel
27 tasks
dkamburov
added
✅ status: verified
…a/row-pinning-export-to-excel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #6972
Reason is we have changed the specification of the base row pinning functionality.
Row pinning now always renders a "fake" ghost row in the original position of the pinned row, hence the data of the pinned record is duplicated.
We cannot export this in excel in a reasonable way, hence row pinning and export to excel will NOT be supported. Grid export will ignore pinned rows.