IgxGrid disabled row implementation. #7104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skrustev
changed the title
…ps://github.com/IgniteUI/igniteui-angular into revert-6972-mkirova/row-pinning-export-to-excel
…a/row-pinning-export-to-excel
…g-export-to-excel Revert "Row pinning + export to excel"
ChronosSF
requested review from
rkaraivanov,
damyanpetev,
simeonoff and
dkamburov
MayaKirova
previously approved these changes
Apr 15, 2020
| @@ -5137,7 +5156,7 @@ export class IgxGridBaseDirective extends DisplayDensityBase implements | |||
| * ``` | |||
| */ | |||
| get dataView(): any[] { | |||
| return this.verticalScrollContainer.igxForOf; | |||
| return this.verticalScrollContainer.igxForOf.map(rec => this.isGhostRecord(rec) ? rec.recordRef : rec) ; | |||
There was a problem hiding this comment.
Is this mapping still necessary? We don't extract the original data from meta data records for other features (like group records, hierarchical records etc.) so unless there is some specific integration scenario that depends on the value to be extracted this is probably not needed.
There was a problem hiding this comment.
Additionally I suspect this getter is called quite a lot around the grid code/templates. With a sufficiently big data, this is basically creating and discarding a new array on each call.
| @@ -89,10 +89,14 @@ export class IgxGridHierarchicalRowPinning implements PipeTransform { | |||
|
|
|||
| constructor(private gridAPI: GridBaseAPIService<IgxHierarchicalGridComponent>) { } | |||
|
|
|||
| public transform(collection: any[], pinnedArea: boolean, pipeTrigger: number): any[] { | |||
| public transform(collection: any[], isPinned: boolean, pipeTrigger: number): any[] { | |||
There was a problem hiding this comment.
As base grid pinning pipe and the one for the hierarchical grid are the same, we can remove the one for hierarchical grid pinning and re-use the base grid one.
10 tasks
…Remove obsolete code and set upinned records in pipe.
MayaKirova
previously approved these changes
Apr 15, 2020
ChronosSF
approved these changes
Apr 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #6926
#6640
Additional information (check all that apply):
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changesIntegration scenarios with ghost rows:
These should be tested.