Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Opening a Thread now correctly marks it as read #1733

Merged
merged 2 commits into from
Mar 4, 2024
Merged

Opening a Thread now correctly marks it as read #1733

merged 2 commits into from
Mar 4, 2024

Conversation

KevinBoulongne
Copy link
Contributor

Depends on #1732

@KevinBoulongne KevinBoulongne added the bug Something isn't working label Mar 1, 2024
@KevinBoulongne KevinBoulongne requested a review from a team as a code owner March 1, 2024 11:00
@github-actions github-actions bot added the dependent This MR depends on another PR label Mar 1, 2024
@KevinBoulongne KevinBoulongne enabled auto-merge March 1, 2024 11:36
@KevinBoulongne KevinBoulongne disabled auto-merge March 1, 2024 11:36
Base automatically changed from prepare-code to master March 1, 2024 12:03
@github-actions github-actions bot removed the dependent This MR depends on another PR label Mar 1, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 1, 2024

This PR/issue depends on:

LunarX
LunarX requested changes Mar 1, 2024
View reviewed changes
Copy link
Contributor

@LunarX LunarX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sometimes my thread is not displayed as "read" when leaving the ThreadFragment but when I open the next thread and come back, the wrongly displayed one is updated and now correctly display as "read"

@KevinBoulongne KevinBoulongne mentioned this pull request Mar 4, 2024
Merged
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Mar 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@LunarX LunarX merged commit dc33ec2 into master Mar 4, 2024
6 checks passed
@LunarX LunarX deleted the fix-read branch March 4, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LunarX LunarX LunarX approved these changes

Assignees

@KevinBoulongne KevinBoulongne

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KevinBoulongne @LunarX