Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete Thread in Realm if it's empty and we're trying to display it in ThreadsList #1876

Merged
merged 3 commits into from
Jun 10, 2024

Conversation

KevinBoulongne
Copy link
Contributor

Depends on #1875

Sometimes, we display an empty Thread in the ThreadsList.

The cause isn't known yet, but in the meantime we just delete them in Realm.
It's possibly because we are out of sync, and the situation will resolve itself shortly.

@KevinBoulongne KevinBoulongne added the bug Something isn't working label May 29, 2024
@KevinBoulongne KevinBoulongne requested a review from a team May 29, 2024 09:48
@github-actions github-actions bot added the dependent This MR depends on another PR label May 29, 2024
@KevinBoulongne KevinBoulongne force-pushed the clean-threadList-callbacks branch from aea89e1 to cba505a Compare May 29, 2024 09:53
@KevinBoulongne KevinBoulongne force-pushed the clean-threadList-callbacks branch from cba505a to 956c896 Compare May 29, 2024 12:31
@KevinBoulongne KevinBoulongne force-pushed the clean-threadList-callbacks branch from 956c896 to 38d267d Compare May 30, 2024 06:44
@KevinBoulongne KevinBoulongne force-pushed the clean-threadList-callbacks branch from 38d267d to 3efc6b1 Compare May 30, 2024 06:50
@KevinBoulongne KevinBoulongne force-pushed the clean-threadList-callbacks branch from 3efc6b1 to c55e67e Compare May 30, 2024 10:23
Copy link
Contributor

@LunarX LunarX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will need to remove all of this once the bug at the root of the issue is fixed. Isn't there a way to easily find back what needs to be removed somehow?

Also, the reason for the change request: Shouldn't we still report to Sentry that this issue occurred and was detected? Maybe even with extra informations we can compute

@KevinBoulongne
Copy link
Contributor Author

We will need to remove all of this once the bug at the root of the issue is fixed. Isn't there a way to easily find back what needs to be removed somehow?

First and foremost, we're not even sure there's a bug here.
I applied the decision that was taken in the 25th of March Monday meeting.

Also, the reason for the change request: Shouldn't we still report to Sentry that this issue occurred and was detected? Maybe even with extra informations we can compute

👍

@KevinBoulongne KevinBoulongne requested a review from LunarX May 31, 2024 06:45
@KevinBoulongne KevinBoulongne enabled auto-merge May 31, 2024 06:45
@KevinBoulongne KevinBoulongne force-pushed the clean-threadList-callbacks branch from c55e67e to 3c94801 Compare May 31, 2024 06:51
@KevinBoulongne KevinBoulongne force-pushed the empty-thread branch 2 times, most recently from 72a3693 to 0b55192 Compare May 31, 2024 07:00
@KevinBoulongne KevinBoulongne force-pushed the clean-threadList-callbacks branch from 3c94801 to 27560c0 Compare May 31, 2024 12:55
Base automatically changed from clean-threadList-callbacks to master June 3, 2024 06:00
@github-actions github-actions bot removed the dependent This MR depends on another PR label Jun 3, 2024
Copy link

github-actions bot commented Jun 3, 2024

This PR/issue depends on:

@KevinBoulongne KevinBoulongne added the rebase Add this label to rebase the PR label Jun 3, 2024
@github-actions github-actions bot removed the rebase Add this label to rebase the PR label Jun 3, 2024
@KevinBoulongne KevinBoulongne added the rebase Add this label to rebase the PR label Jun 4, 2024
@github-actions github-actions bot removed the rebase Add this label to rebase the PR label Jun 4, 2024
@KevinBoulongne KevinBoulongne force-pushed the empty-thread branch 2 times, most recently from ff8732a to 73d9f75 Compare June 4, 2024 09:22
@KevinBoulongne KevinBoulongne added the rebase Add this label to rebase the PR label Jun 6, 2024
@github-actions github-actions bot removed the rebase Add this label to rebase the PR label Jun 6, 2024
@KevinBoulongne KevinBoulongne added the rebase Add this label to rebase the PR label Jun 10, 2024
@github-actions github-actions bot removed the rebase Add this label to rebase the PR label Jun 10, 2024
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@KevinBoulongne KevinBoulongne merged commit d5d2e21 into master Jun 10, 2024
4 checks passed
@KevinBoulongne KevinBoulongne deleted the empty-thread branch June 10, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants