-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete Thread in Realm if it's empty and we're trying to display it in ThreadsList #1876
Conversation
aea89e1
to
cba505a
Compare
2f3f3ae
to
22c4f74
Compare
cba505a
to
956c896
Compare
22c4f74
to
256ce0b
Compare
956c896
to
38d267d
Compare
256ce0b
to
6df8c57
Compare
38d267d
to
3efc6b1
Compare
6df8c57
to
b670b47
Compare
3efc6b1
to
c55e67e
Compare
b670b47
to
464f285
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will need to remove all of this once the bug at the root of the issue is fixed. Isn't there a way to easily find back what needs to be removed somehow?
Also, the reason for the change request: Shouldn't we still report to Sentry that this issue occurred and was detected? Maybe even with extra informations we can compute
First and foremost, we're not even sure there's a bug here.
👍 |
c55e67e
to
3c94801
Compare
72a3693
to
0b55192
Compare
3c94801
to
27560c0
Compare
0b55192
to
19c23cb
Compare
This PR/issue depends on:
|
app/src/main/java/com/infomaniak/mail/ui/main/folder/ThreadListAdapter.kt
Show resolved
Hide resolved
19c23cb
to
7056f3e
Compare
c4058f9
to
bf22e90
Compare
ff8732a
to
73d9f75
Compare
73d9f75
to
152e69b
Compare
app/src/main/java/com/infomaniak/mail/data/cache/mailboxContent/ThreadController.kt
Show resolved
Hide resolved
152e69b
to
24043e3
Compare
|
Depends on #1875
Sometimes, we display an empty Thread in the ThreadsList.
The cause isn't known yet, but in the meantime we just delete them in Realm.
It's possibly because we are out of sync, and the situation will resolve itself shortly.