Execute actions right away instead of waiting for API call result #2016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tevincent
commented
Aug 19, 2024
•
tevincent
commented
- Marked as read/unread/favorite/unfavorite
- Update locally immediately
- Make WS call
- If there's an error, reset to previous value
- Move/Delete
- Create a local variable in Realm (isMovedOutLocally) and if it is being moved, set this value to true without waiting for the API to return. When displaying the ThreadList, filter on isMovedOutLocally == false
- If there's an error, return as before
|
tevincent
force-pushed
the
instant-action
branch
2 times, most recently
from
23eb4ab to
c090bac
Compare
KevinBoulongne
force-pushed
the
instant-action
branch
from
c090bac to
acdfc33
Compare
KevinBoulongne
force-pushed
the
instant-action
branch
from
acdfc33 to
1c09c10
Compare
KevinBoulongne
force-pushed
the
instant-action
branch
from
a49fe11 to
2316594
Compare
KevinBoulongne
force-pushed
the
instant-action
branch
from
2316594 to
10b488b
Compare
…tion to avoid blocking database when network is slow as frak
KevinBoulongne
force-pushed
the
instant-action
branch
from
ab11472 to
c466af4
Compare
KevinBoulongne
approved these changes
Oct 3, 2024
tevincent
force-pushed
the
instant-action
branch
from
41e2992 to
a92d728
Compare
tevincent
force-pushed
the
instant-action
branch
from
a92d728 to
5841715
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.