When expanding a long Thread, display Messages by batches so it doesn't freeze the UI anymore #2044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevinBoulongne
force-pushed
the
open-thread-freeze
branch
2 times, most recently
from
4cf2c97 to
cc4cc09
Compare
KevinBoulongne
force-pushed
the
open-thread-freeze
branch
from
cc4cc09 to
5ff3762
Compare
LunarX
previously requested changes
Sep 18, 2024
app/src/main/java/com/infomaniak/mail/ui/main/thread/ThreadFragment.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/infomaniak/mail/ui/main/thread/ThreadViewModel.kt
Outdated
Show resolved
Hide resolved
KevinBoulongne
force-pushed
the
open-thread-freeze
branch
from
5ff3762 to
e0dc712
Compare
|
Why do we do all of this again though? |
KevinBoulongne
force-pushed
the
open-thread-freeze
branch
from
f4a0c0c to
0ad8281
Compare
|
Is there no other way to avoid the freeze instead of having to introduce this unconventional delay between messages? A more conventional way. |
tevincent
requested changes
Sep 23, 2024
app/src/main/java/com/infomaniak/mail/ui/main/thread/ThreadViewModel.kt
Outdated
Show resolved
Hide resolved
KevinBoulongne
force-pushed
the
open-thread-freeze
branch
2 times, most recently
from
188cbea to
f5a5867
Compare
KevinBoulongne
force-pushed
the
open-thread-freeze
branch
2 times, most recently
from
7a2a571 to
7e1023b
Compare
KevinBoulongne
force-pushed
the
open-thread-freeze
branch
3 times, most recently
from
63f8435 to
f40b3b6
Compare
KevinBoulongne
force-pushed
the
open-thread-freeze
branch
2 times, most recently
from
982d3ed to
aa61eda
Compare
KevinBoulongne
force-pushed
the
open-thread-freeze
branch
2 times, most recently
from
7d861e5 to
1eed1dd
Compare
KevinBoulongne
force-pushed
the
open-thread-freeze
branch
2 times, most recently
from
d42a194 to
0879c64
Compare
KevinBoulongne
force-pushed
the
open-thread-freeze
branch
4 times, most recently
from
033a6ef to
a10eded
Compare
KevinBoulongne
force-pushed
the
open-thread-freeze
branch
3 times, most recently
from
a316a5e to
6afbfdd
Compare
… doesn't freeze the UI anymore
KevinBoulongne
force-pushed
the
open-thread-freeze
branch
2 times, most recently
from
42f3660 to
794007f
Compare
tevincent
approved these changes
Nov 4, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the situation of a Thread long enough so we display the SuperCollapsedBlock :