Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor profile view and how we can add a mailbox #2054

Merged
merged 17 commits into from
Oct 1, 2024
Merged

Refactor profile view and how we can add a mailbox #2054

merged 17 commits into from
Oct 1, 2024

Conversation

tevincent
Copy link
Contributor

@tevincent tevincent commented Sep 26, 2024 •
edited
Loading

new_profile.mp4

@tevincent tevincent force-pushed the new-profile-view branch 4 times, most recently from 20c2401 to 8d236a1 Compare September 26, 2024 14:21
@LunarX LunarX self-requested a review September 27, 2024 06:37
LunarX
LunarX requested changes Sep 27, 2024
View reviewed changes
@tevincent tevincent added the rebase Add this label to rebase the PR label Sep 27, 2024
@github-actions github-actions bot removed the rebase Add this label to rebase the PR label Sep 27, 2024
LunarX
LunarX requested changes Sep 27, 2024
View reviewed changes
LunarX
LunarX requested changes Sep 30, 2024
View reviewed changes
LunarX
LunarX requested changes Sep 30, 2024
View reviewed changes
Copy link
Contributor

@LunarX LunarX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tools:context=".ui.main.user.AccountFragment" in fragment_attach_mailbox is not correct anymore, it points to a wrong fragment

LunarX
LunarX requested changes Sep 30, 2024
View reviewed changes
Copy link
Contributor

@LunarX LunarX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tools:context=".ui.main.user.AccountFragment" in fragment_attach_mailbox is not correct anymore, it points to a wrong fragment

@tevincent tevincent force-pushed the new-profile-view branch 3 times, most recently from 725f428 to 3a5cd74 Compare September 30, 2024 12:40
@tevincent tevincent added the rebase Add this label to rebase the PR label Oct 1, 2024
@github-actions github-actions bot removed the rebase Add this label to rebase the PR label Oct 1, 2024
@tevincent tevincent force-pushed the new-profile-view branch 2 times, most recently from 0a96203 to 0c956de Compare October 1, 2024 07:03
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Oct 1, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@tevincent tevincent merged commit 649a50d into master Oct 1, 2024
4 checks passed
@tevincent tevincent deleted the new-profile-view branch October 1, 2024 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LunarX LunarX LunarX approved these changes

Assignees

@tevincent tevincent

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tevincent @LunarX