feat: Order threads by their new internal date field #2239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ting date as two different api fields
KevinBoulongne
force-pushed
the
internal-date
branch
from
605cc86 to
29dfb29
Compare
|
KevinBoulongne
approved these changes
Mar 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The api now returns an
internal_datefield. Because some messages might not provide a date, the api has aninternal_datefield will never be null and if the message's date would be null, then the api will record the first time it saw that mail instead insideinternal_date.This new
internal_dateneeds to be used for every form of sorting inside the app while the old date field needs to be used when displaying a message's date. Theinternal_datecan be a fallback so we have something to display in case the old date is not defined.I still need to find a better name for the old date property that I currently called
originalDate. I'm looking for ideas