feat: Custom folder sorting can be parametrized easily for any folder role #2240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevinBoulongne
approved these changes
Mar 10, 2025
KevinBoulongne
force-pushed
the
internal-date
branch
from
605cc86 to
29dfb29
Compare
KevinBoulongne
force-pushed
the
snooze-message-ordering
branch
from
c55fda9 to
a99e7ff
Compare
|
|
This PR/issue depends on:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The snooze folder needs a new order for its threads, I took this opportunity to centralize and make it easily parametrisable.
For the snooze folder, not only did I need to change the order from the default descending order to an ascending order, but I also needed to sort by another property of the Thread model.
The goal is to have the Threads that will first be unsnoozed at the top of the screen
Depends on #2239