Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

try to fix global timestamp mapping issue when HW timestamp is rollback to 0 #12451

Merged

Conversation

mengyui
Copy link
Contributor

@mengyui mengyui commented Nov 28, 2023

HW timestamp is 32bit.
when the HW timestamp is rollbacked to 0 from 2^32, the global timestamp may drift a little in about 1 second.

the value of _base_sample._x is copied from the HW timestamp.
the value of _base_sample._y is host timestamp.
when the HW timestamp is rollback, _x should be changed.

@Nir-Az Nir-Az requested a review from ev-mp November 29, 2023 18:30
@Nir-Az Nir-Az requested review from remibettan and removed request for ev-mp February 13, 2024 15:15
Copy link
Contributor

@remibettan remibettan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Behavior of global timestamp on hardware timestamp rollback is improved by this change.
Great catch.

@remibettan remibettan merged commit 3f8174b into IntelRealSense:development Jul 28, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants