Fix Coverity issues #12465
Merged
Fix Coverity issues #12465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please add "Coverity issues" to the PR title not just numbers. It does not have to include the numbers in the title, can have them in the description. |
OhadMeir
reviewed
Dec 3, 2023
src/ds/ds-motion-common.cpp
Outdated
| auto st = p->get_stream_type(); | ||
|
|
There was a problem hiding this comment.
Better to perform the check immediately after the cast.
- locality - easier to see the connection
- efficiency - not performing needless operation in case of failure
There was a problem hiding this comment.
I will learn it. Fixed.
OhadMeir
reviewed
Dec 3, 2023
src/gl/upload.cpp
Outdated
| @@ -77,6 +77,10 @@ namespace librealsense | |||
| auto gf = dynamic_cast<gpu_addon_interface*>((frame_interface*)new_f.get()); | |||
|
|
|||
| uint32_t output_yuv; | |||
|
|
|||
There was a problem hiding this comment.
Same, success checks should be right after the action.
OhadMeir
reviewed
Dec 3, 2023
OhadMeir
approved these changes
Dec 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.