Coverity - Uncaught exception

include/librealsense2/hpp/rs_device.hpp

@@ -837,7 +837,7 @@ namespace rs2
 
         void on_calibration_change( rs2_calibration_status status ) noexcept override
         {
-            _callback( status );
+            _callback(status);
         }
         void release() override { delete this; }
     };

src/callback-invocation.h

@@ -44,8 +44,17 @@ struct callback_invocation_holder
 
     ~callback_invocation_holder()
     {
-        if( invocation )
-            owner->deallocate( invocation );
+        if (invocation)
+        {
+            try
+            {
+                owner->deallocate(invocation);
+            }
+            catch (...)
+            {
+                LOG_INFO("Exception occurred during callback_invocation_holder destruction");
+            }
+        }
     }
 
     callback_invocation_holder & operator=( callback_invocation_holder && other )

src/gl/align-gl.cpp

@@ -274,8 +274,15 @@ align_gl::align_gl(rs2_stream to_stream) : align(to_stream, "Align (GLSL)")
 
 align_gl::~align_gl()
 {
-    perform_gl_action([&]()
+    try
     {
-        cleanup_gpu_resources();
-    }, []{});
+        perform_gl_action([&]()
+        {
+            cleanup_gpu_resources();
+        }, [] {});
+    }
+    catch (...)
+    {
+        LOG_INFO("Exception occurred during align_gl destruction");
+    }
 }

src/gl/colorizer-gl.cpp

@@ -175,10 +175,17 @@ namespace librealsense
 
         colorizer::~colorizer()
         {
-            perform_gl_action([&]()
+            try
+            {
+                perform_gl_action([&]()
+                    {
+                        cleanup_gpu_resources();
+                    }, [] {});
+            }
+            catch (...)
             {
-                cleanup_gpu_resources();
-            }, []{});
+                LOG_INFO("Exception occurred during colorizer destruction");
+            }
         }
 
         void colorizer::populate_floating_histogram(float* f, int* hist)

src/gl/pointcloud-gl.cpp

@@ -388,10 +388,17 @@ void pointcloud_gl::create_gpu_resources()
 
 pointcloud_gl::~pointcloud_gl()
 {
-    perform_gl_action([&]()
+    try
     {
-        cleanup_gpu_resources();
-    }, []{});
+        perform_gl_action([&]()
+        {
+            cleanup_gpu_resources();
+        }, [] {});
+    }
+    catch (...)
+    {
+        LOG_INFO("Exception occurred during pointcloud_gl destruction");
+    }
 }
 
 pointcloud_gl::pointcloud_gl()

src/gl/synthetic-stream-gl.cpp

@@ -186,9 +186,16 @@ namespace librealsense
         gpu_section::~gpu_section()
         {
             backup_content = false;
-            perform_gl_action([&](){
-                cleanup_gpu_resources();
-            }, []{});
+            try
+            {
+                perform_gl_action([&]() {
+                    cleanup_gpu_resources();
+                    }, [] {});
+            }
+            catch (...)
+            {
+                LOG_INFO("Exception occurred during gpu_section destruction");
+            }
         }
 
         void gpu_section::create_gpu_resources()

src/gl/upload.cpp

@@ -43,10 +43,17 @@ namespace librealsense
 
         upload::~upload()
         {
-            perform_gl_action([&]()
+            try
             {
-                cleanup_gpu_resources();
-            }, [] {});
+                perform_gl_action([&]()
+                {
+                    cleanup_gpu_resources();
+                }, [] {});
+            }
+            catch (...)
+            {
+                LOG_INFO("Exception occurred during upload destruction");
+            }
         }
 
         void upload::cleanup_gpu_resources()

src/gl/y4112rgb-gl.cpp

@@ -135,10 +135,17 @@ y411_2rgb::y411_2rgb()
 
 y411_2rgb::~y411_2rgb()
 {
-    perform_gl_action([&]()
+    try
+    {
+        perform_gl_action([&]()
+        {
+            cleanup_gpu_resources();
+        }, [] {});
+    }
+    catch (...)
     {
-        cleanup_gpu_resources();
-    }, []{});
+        LOG_INFO("Exception occurred during y411_2rgb destruction");
+    }
 }
 
 rs2::frame y411_2rgb::process_frame(const rs2::frame_source& src, const rs2::frame& f)

src/gl/yuy2rgb-gl.cpp

@@ -118,10 +118,17 @@ yuy2rgb::yuy2rgb()
 
 yuy2rgb::~yuy2rgb()
 {
-    perform_gl_action([&]()
+    try
     {
-        cleanup_gpu_resources();
-    }, []{});
+        perform_gl_action([&]()
+            {
+                cleanup_gpu_resources();
+            }, [] {});
+    }
+    catch (...)
+    {
+        LOG_INFO("Exception occurred during yuy2rgb destruction");
+    }
 }
 
 rs2::frame yuy2rgb::process_frame(const rs2::frame_source& src, const rs2::frame& f)

src/hw-monitor.h

@@ -225,7 +225,14 @@ namespace librealsense
 
         ~locked_transfer()
         {
-            _heap.wait_until_empty();
+            try
+            {
+                _heap.wait_until_empty();
+            }
+            catch (...)
+            {
+                LOG_INFO("Exception occurred during locked_transfer destruction");
+            }
         }
     private:
         std::shared_ptr<platform::command_transfer> _command_transfer;

src/linux/backend-hid.cpp

@@ -56,7 +56,14 @@ namespace librealsense
 
         hid_input::~hid_input()
         {
-            enable(false);
+            try
+            {
+                enable(false);
+            }
+            catch (...)
+            {
+                LOG_INFO("Exception occurred during hid_input destruction");
+            }
         }
 
         // enable scan input. doing so cause the input to be part of the data provided in the polling.
@@ -954,7 +961,14 @@ namespace librealsense
         {
             for (auto& elem : _streaming_iio_sensors)
             {
-                elem->stop_capture();
+                try
+                {
+                    elem->stop_capture();
+                }
+                catch (...)
+                {
+                    LOG_INFO("An exception occurred during stopping a sensor");
+                }
             }
 
             for (auto& elem : _streaming_custom_sensors)

src/linux/backend-v4l2.cpp

@@ -178,7 +178,14 @@ namespace librealsense
 
         named_mutex::~named_mutex()
         {
-            unlock();
+            try
+            {
+                unlock();
+            }
+            catch (...)
+            {
+                LOG_INFO("Exception occurred during named_mutex destruction");
+            }
         }
 
         void named_mutex::lock()

src/linux/udev-device-watcher.cpp

@@ -179,8 +179,14 @@ udev_device_watcher::udev_device_watcher( const platform::backend * backend )
 
 udev_device_watcher::~udev_device_watcher()
 {
-    stop();
-
+    try
+    {
+        stop();
+    }
+    catch (...)
+    {
+        LOG_INFO("Exception occurred during stopping udev device watcher");
+    }
     /* Release the udev monitor */
     if( _udev_monitor )
         udev_monitor_unref( _udev_monitor );

src/sync.cpp

@@ -79,7 +79,14 @@ namespace librealsense
             LOG_WARNING(callbacks_inflight << " callbacks are still running on some other threads. Waiting until all callbacks return...");
         }
         // wait until user is done with all the stuff he chose to borrow
-        _callback_inflight.wait_until_empty();
+        try
+        {
+            _callback_inflight.wait_until_empty();
+        }
+        catch (...)
+        {
+            LOG_INFO("Exception occurred in time waiting for empty callback");
+        }
     }
 
     identity_matcher::identity_matcher(stream_id stream, rs2_stream stream_type)